Re: wave tests patch

2004-08-16 Thread Eric Pouech
The problem with sharing this code in winmm.c is that we need to know what's the device format and I'm not sure how to do that from winmm.c. there's no API AFAIK, but we could always cache the format in winmm's internal reprensentations. A+

Re: wave tests patch

2004-08-16 Thread Francois Gouget
On Sun, 15 Aug 2004, Eric Pouech wrote: [...] > coming back from vacation, and starting browsing thru the pile of e-mail > (I'm not sure of the final output of this discussion). > How about, letting the drivers decide which format they support (in > ???_GETPOS message handling) and have the fallb

Re: wave tests patch

2004-08-14 Thread Eric Pouech
Francois Gouget a écrit : Francois Gouget wrote: [...] Anyway, assuming that we need to round up I propose to modify the implementation as in the attached patch. The advantage is that it does not rely on ceil(). In fact it doesn't even use floating point arithmetic so we cannot get any rounding

Re: wave tests patch

2004-07-20 Thread Francois Gouget
Francois Gouget wrote: [...] Anyway, assuming that we need to round up I propose to modify the implementation as in the attached patch. The advantage is that it does not rely on ceil(). In fact it doesn't even use floating point arithmetic so we cannot get any rounding error. The code that perfo

Re: wave tests patch

2004-07-20 Thread Francois Gouget
Robert Reif wrote: Notify when position format not supported. Test that position is 0 at start. Good patch. I was worried that tracing all waveGetPosition() failures would clober the output but after that's what one wants when tracing is enabled. Plus it uncovers interesting results: wave.c:584: