Re: version.dll patch

2004-03-21 Thread Jakob Eriksson
Mike Hearn wrote: On Sat, 20 Mar 2004 11:10:53 +0100, Jakob Eriksson wrote: Delenda est Carthago. Eh, no I mean some kind mandatory indent would be nice. :-) This is what gstreamer does. They run all code through GNU indent first to get consistent code style. Though I don't know if tryin

Re: version.dll patch

2004-03-21 Thread Marcus Meissner
On Sun, Mar 21, 2004 at 04:47:22PM +, Mike Hearn wrote: > On Sat, 20 Mar 2004 11:10:53 +0100, Jakob Eriksson wrote: > > Delenda est Carthago. Eh, no I mean some kind mandatory indent would be > > nice. :-) > This is what gstreamer does. They run all code through GNU indent first to > get co

Re: version.dll patch

2004-03-21 Thread Mike Hearn
On Sat, 20 Mar 2004 11:10:53 +0100, Jakob Eriksson wrote: > Delenda est Carthago. Eh, no I mean some kind mandatory indent would be > nice. :-) This is what gstreamer does. They run all code through GNU indent first to get consistent code style. Though I don't know if trying to settle on one sty

Re: version.dll patch

2004-03-20 Thread Jakob Eriksson
Dimitrie O. Paun wrote: On March 19, 2004 8:13 pm, Alexandre Julliard wrote: Also the whole file has been reformatted, making it impossible to see what changed. Please don't do that. One more note: the file seems to have been edited with a tab setting of 4. Please don't redefine tab, keep

Re: version.dll patch

2004-03-19 Thread Dimitrie O. Paun
On March 19, 2004 8:13 pm, Alexandre Julliard wrote: > Also the whole file has been reformatted, making it impossible to see > what changed. Please don't do that. One more note: the file seems to have been edited with a tab setting of 4. Please don't redefine tab, keep it to the standard 8, other

Re: version.dll patch

2004-03-19 Thread Alexandre Julliard
Steven Edwards <[EMAIL PROTECTED]> writes: > We found quite a few problems using version.dll on ReactOS and Windows > XP. According to Royce there was a issue regarding ANSI converion that > was causing applications (Winzip) to fail to load. Also we found that > Microsoft doesnt support reading of