Re: user32: test what FindWindow when window isn't found

2008-08-14 Thread Dmitry Timoshkov
"Austin English" <[EMAIL PROTECTED]> wrote: > Thanks for the comments! Here's an updated patch. Passes in Win2K. This still doesn't look ok to me (missing SetLastError beforehand, indentation, spacing, braces). There is no need to add a new test, just add the SetLastError(0xdeadbeef) call before

Re: user32: test what FindWindow when window isn't found

2008-08-14 Thread Juan Lang
Hi Austin, +found = FindWindow("SomeWindowThatDoesNotExist", NULL); +if(found) { + printf("found not NULL"); +} Please don't use printf in the tests. If you must log something, use trace, but I don't think it's that useful in this case, since we really expect it not to be found.

Re: user32: test what FindWindow when window isn't found

2008-08-14 Thread Austin English
On Wed, Aug 13, 2008 at 10:09 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Austin English" <[EMAIL PROTECTED]> wrote: > >> -/* test FindWindow behavior */ >> +SetLastError(0xdeadbeef); >> +HWND hWnd = FindWindow("SomeWindowThatDoesNotExist", NULL); >> +if(hWnd) { >> + pri

Re: user32: test what FindWindow when window isn't found

2008-08-13 Thread Dmitry Timoshkov
"Austin English" <[EMAIL PROTECTED]> wrote: > -/* test FindWindow behavior */ > +SetLastError(0xdeadbeef); > +HWND hWnd = FindWindow("SomeWindowThatDoesNotExist", NULL); > +if(hWnd) { > + printf("hWnd not NULL"); > +} > +else { > + > + todo_wine > + ok(GetLastE