RE: [PATCH2+TEST] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-14 Thread Hongbo Ni
> > ==> > > > # Patch> > > > ==> > > > --- wine-1.1.1-orig/dlls/user32/win.c 2008-07-12 01:55:55.0 > > +1000> > +++ wine-1.1.1/dlls/us

Re: [PATCH2+TEST] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-14 Thread Rob Shearman
2008/7/14 Hongbo Ni <[EMAIL PROTECTED]>: > > Now I have fixed the problem, or corrected to window behaviour. Included is > the Patch, Test and Debug (play with windows). Can anyone please test or > comment ? > > Regards > Hongbo Ni > > ==

[PATCH2+TEST] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-14 Thread Hongbo Ni
Hello, Now I have fixed the problem, or corrected to window behaviour. Included is the Patch, Test and Debug (play with windows). Can anyone please test or comment ? Regards Hongbo Ni == # Patch ==

RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-12 Thread Hongbo Ni
Hi Everyone, It turns out my previous patch was not right to solve the problem. After writing a win32 application for debuging the impact of SetClassLongW, I found out that something is abnormal in windows. After a built-in class (which has procA and procW) is subclassed by SetClassLong(Ptr)

RE: [PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Hongbo Ni
Dear Reece, Thanks for your comments. > > I have write a patch for the problem, please comment.> > + if( unicode && > > class->winproc == EDIT_winproc_handle )> > Is it just the EDIT window > > procedure that is affected? I suspect that> this will apply to all classes > > that have A and W var

Re: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread MikoĊ‚aj Zalewski
As it was written, you need to write some more tests for such changes. It required a few iterations before we got SetWindowLongPtr(GWLP_WNDPROC, ...) right, so this might be also not easy. The tests for SetWindowLongPtr are in dlls/user32/tests/class.c. Some things I can think of that require

Re: [PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Reece Dunn
2008/7/10 Hongbo Ni <[EMAIL PROTECTED]>: > I have write a patch for the problem, please comment. > +if( unicode && class->winproc == EDIT_winproc_handle ) Is it just the EDIT window procedure that is affected? I suspect that this will apply to all classes that have A and W variants. I als

[PATCH] RE: user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-10 Thread Hongbo Ni
___ > From: [EMAIL PROTECTED] > To: wine-devel@winehq.org > Subject: user32: Problem using SetClassLongW to subclass built-in control > (Edit) > Date: Wed, 9 Jul 2008 22:06:22 +1000 > > Hi, > > Summary: SetClassLongW(hEdit, GCL_WNDPROC,(DWORD)NewEditWndP

user32: Problem using SetClassLongW to subclass built-in control (Edit)

2008-07-09 Thread Hongbo Ni
Hi, Summary: SetClassLongW(hEdit, GCL_WNDPROC,(DWORD)NewEditWndProc) in Wine differs from Windows. Background: when a standard built-in window class (such as Edit for example) is registered initially, the window system register the class with two Procedures (procA and ProcW) and assign a