Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Boaz Harrosh
Mike McCormack wrote: I considered writing a program to generate the code, since it is boilerplate code. The input could be the header file for the class factory, and the output the implementation. Adding more non-standard header files may not be a direction we want to head in... Mike Rrr, a

Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Mike Hearn
Or even better, a single implementation in a header file in include/wine Bonus points for also making a common regsvr implementation too. ... And if you convince Alexandre to let us have a wine utilities DLL rather than putting ever more code into inline functions, you win a free stuffed toy :)

Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Robert Shearman
Mike McCormack wrote: Robert Shearman wrote: Or even better, a single implementation in a header file in include/wine Bonus points for also making a common regsvr implementation too. I considered writing a program to generate the code, since it is boilerplate code. The input could be the header

Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Mike McCormack
Robert Shearman wrote: Or even better, a single implementation in a header file in include/wine Bonus points for also making a common regsvr implementation too. I considered writing a program to generate the code, since it is boilerplate code. The input could be the header file for the class fac

Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Robert Shearman
Mike McCormack wrote: Huw D M Davies wrote: Good catch. This classfactory code is fairly pervasive in Wine. I'll submit a patch fixing all other occurrences of this in a moment. Maybe we should make a new janitorial task to turn all those class factories into singleton into objects too. It's no

Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Mike McCormack
Huw D M Davies wrote: Good catch. This classfactory code is fairly pervasive in Wine. I'll submit a patch fixing all other occurrences of this in a moment. Maybe we should make a new janitorial task to turn all those class factories into singleton into objects too. It's not necessary to allocat

Re: urlmon: IInternetSecurityManager

2004-09-28 Thread Mike Hearn
The convention with COM interfaces is to use the CoTaskMemAlloc / CoTaskMemFree memory management functions instead of the Heap ones (even though they are the same). This is just a slight nit-pick. Hmm, I don't think we should encourage using these APIs. It just makes the code less clear and peo