Re: dlls/explorerframe: build tests with -D__WINESRC__

2013-10-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2750 Your par

Re: [2/4] dnsapi/tests: Compile with -D__WINESRC__.

2013-10-14 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2733 Your par

Re: winmm/tests: Use BOOL type where appropriate

2013-10-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2721 Your par

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-11 Thread Qian Hong
Hmm... It still fails today. I have a better idea to fix it, will send a patch tomorrow. Sorry for introducing the failures :(

Fwd: Re: kernel32/tests: Add tests for job objects (try 7)

2013-10-11 Thread Andrew Cook
(no idea why my client sent this to wine-patches) On 10/10/13 15:23, Andrew Cook wrote: > --- > dlls/kernel32/tests/process.c | 159 > +- > include/winbase.h | 1 + > include/winnt.h | 90

Re: mshtml: Compile tests with __WINESRC__ define.

2013-10-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2689 Your par

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-10 Thread Qian Hong
n increase the timeout value from 120 to something > like 1800? Oh, forgot to say: the test failures are most likely caused by side effects of other tests, I can't reproduce it on our testbots if only winstation tests are executed, that is why I asked for increasing the timeout so I c

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-10 Thread Qian Hong
Hello, On Thu, Oct 10, 2013 at 6:48 PM, Alexandre Julliard wrote: > Can you please fix the test failures introduced by your previous changes > first? cf. https://test.winehq.org/data/tests/user32:winstation.html Sorry for introduced the failures, I'd like to investigate, howe

Re: ieframe: Compile tests with __WINESRC__ define.

2013-10-10 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2688 Your par

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.

2013-10-10 Thread Alexandre Julliard
Qian Hong writes: > --- > dlls/user32/tests/winstation.c | 57 > > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:win

Re: kernel32/tests: Add tests for job objects (try 7)

2013-10-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2683 Your par

Re: ddraw/tests: Use BOOL type where appropriate

2013-10-09 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2682 Your par

Re: ws2_32/tests: Use BOOL type where appropriate

2013-10-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2674 Your par

Re: gdi32/tests: Skip linked font like SimSun-ExtB in fixed-pitch font selection.

2013-10-08 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2669 Your par

Re: msi/tests: Use BOOL type where appropriate (resend)

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2667 Your par

Re: msi/tests: Use BOOL type where appropriate

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2660 Your par

Re: mshtml/tests: Fix compilation on systems that don't support nameless unions.

2013-10-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2637 Your par

Re: kernel32/tests: Fix compilation on systems that don't support nameless unions.

2013-10-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2634 Your par

Re: [PATCH 5/5] wininet: Added InternetLockRequestFile tests.

2013-10-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2625 Your par

Re: kernel32: Add tests for job objects (try 4)

2013-10-03 Thread Alexandre Julliard
Andrew Cook writes: > +sprintf(buffer, "\"%s\" tests/process.c ignored \"%s\"", selfname, > "wait"); > + > +IOPort = CreateIoCompletionPort(INVALID_HANDLE_VALUE, NULL, 0, 1); > +ok(IOPort != INVALID_HANDL

Re: [3/5] ws2_32: Add some tests for getpeername.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2608 Your par

Re: [PATCH 2/7] qedit/tests: Use the W version of FindResource().

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2455 Your par

Re: [PATCH 4/7] msvcr90/tests: Use the W form of CreateEvent().

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2457 Your par

Re: Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2434 Your par

Re: kernel32: Add tests for job objects (try 3)

2013-10-02 Thread Nikolay Sivov
p; strcmp(option, "wait") == 0) { +/* for job object tests */ +Sleep(3000); +return; +} Is it really necessary?

Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-01 Thread Francois Gouget
"Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".commit d6f4c73ceb4640332c79561b4e8e7c23619aa669 Author: Francois Gouget Date: Mon Sep 30 19:26:50 2013 +0200 kernel32/tests: Serial port trigger-level test patch.

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Nikolay Sivov
nt making them 'const'. I'm matching the formatting of existing code: http://source.winehq.org/source/dlls/kernel32/tests/file.c#L65 Also, what's the point of not making them const? +static DWORD WINAPI progress(LARGE_INTEGER TotalFileSize, +L

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Juan Lang
t;> +} ; >>> >> I don't see a point making them 'const'. >> > I'm matching the formatting of existing code: > http://source.winehq.org/source/dlls/kernel32/tests/file.c#L65 > Also, what's the point of not making them const? > It&#

Re: mmdevapi/tests: test MMDevPropStore_GetAt

2013-09-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2403 Your par

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-29 Thread Daniel Jeliński
const BOOL copy_retval;/* expected CopyFileEx result */ >> +const DWORD lastError; /* expected CopyFileEx error code >> */ >> +} ; >> > I don't see a point making them 'const'. > I'm matching the formatting of existing

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-29 Thread Nikolay Sivov
On 9/30/2013 00:51, Daniel Jeliński wrote: +struct progress_list { +const DWORD progress_retval_init; /* value to return from progress routine */ +const BOOL cancel_init;/* value to set Cancel flag to */ +const DWORD progress_retval_end; /* value to return from progr

Re: [1/3] ws2_32/tests: Fix an ok() call comment

2013-09-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2392 Your par

Re: [1/2] ws2_32/tests: Fix an ok() call comment

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2387 Your par

Re: [PATCH 2/2] mshtml: Added IHTMLFormElement::sumit tests.

2013-09-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2374 Your par

Re: kernel32/tests: Add DuplicateHandle test to the file access tests.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2345 Your par

Re: [PATCH 4/5] d3d8/tests: Add a volume V16U16 test.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2318 Your par

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2317 Your par

Re: advapi32/tests: Mark a test result as broken.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2315 Your par

Re: [1/2] winhttp/tests: Remove explicit zero-intialization of static data.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2314 Your par

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-23 Thread Stefan Dösinger
; support. Nvidia has V16U16, AMD supports Q8W8V8U8, at least on >>> r200. I am working on a more comprehensive converted format >>> test that tests all supported signed formats with surfaces. >> Just out of curiosity, do you happen to know if any >> hardware/driver suppor

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-23 Thread Stefan Dösinger
am >> working on a more comprehensive converted format test that tests >> all supported signed formats with surfaces. > Just out of curiosity, do you happen to know if any > hardware/driver supports these for render targets? I think d3d10+ cards do. This is from memory, I'll

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-23 Thread Henri Verbeet
On 23 September 2013 13:29, Stefan Dösinger wrote: > Note that Windows drivers disagree on which format they support. Nvidia > has V16U16, AMD supports Q8W8V8U8, at least on r200. I am working on a > more comprehensive converted format test that tests all supported signed > formats w

Re: [3/4] kernel32/tests: Add 0-length read tests for a pipe.

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2250 Your par

Re: [PATCH 4/6] d3d9/tests: Add a volume V16U16 test.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2291 Your par

Re: [PATCH 5/6] d3d8/tests: Add a volume V16U16 test.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2292 Your par

Re: [PATCH 1/5] ddraw/tests: Add a test for render target surface capabilities.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2289 Your par

Re: [3/3] d3d9/tests: Implemented tests for IDirect3DSwapChain9Ex_GetDisplayModeEx

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2282 Your par

Re: [2/3] d3d9/tests: Test if IDirect3DSwapChain9Ex is available with IDirect3D9(Ex)

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2281 Your par

Re: [PATCH 4/4] mshtml: Added external MIME handling tests.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2275 Your par

Re: ws2_32/tests: Mark WinNT result as broken

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2271 Your par

Re: [PATCH 4/5] d3d8/tests: Add tests for block-based volume formats.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2269 Your par

Re: [PATCH 5/5] d3d8/tests: Test invalid volume lock boxes.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2270 Your par

Re: [PATCH 1/5] d3d9/tests: Read the caps from the device.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2268 Your par

Re: shlwapi/tests: Fix stream test failures under some win2000 versions.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2266 Your par

Re: [PATCH 2/2] d3dx9/tests: Add matrix column register count clamp test.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2259 Your par

Re: [PATCH 5/5] d3d9/tests: Test invalid volume lock boxes.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2254 Your par

Re: [PATCH 4/5] d3d9/tests: Add tests for block-based volume formats (try 2).

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2253 Your par

Re: [PATCH 8/8] d3d9/tests: Test invalid volume lock boxes.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2234 Your par

Re: [PATCH 1/8] d3dx9_36/tests: Create*TextureFromFileInMemory doesn't fail.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2231 Your par

Re: [PATCH 7/8] d3d9/tests: Add tests for block-based volume formats.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2233 Your par

Re: Asynchronous read/write tests in ntdll/tests/file.c

2013-09-18 Thread Thomas Faber
On 2013-09-18 11:31, Dmitry Timoshkov wrote: > Thomas Faber wrote: >> status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, >> sizeof(contents), &offset, NULL); >> ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below >> */, "expected STATUS_PENDING, got %#x\n", stat

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 3)

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2221 Your par

Re: msvcrt/tests: Load the correct function on ARM

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key= Your par

Re: [1/2] shlwapi/tests: Add a read/write test for IStream on files.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2214 Your par

Re: Asynchronous read/write tests in ntdll/tests/file.c

2013-09-18 Thread Dmitry Timoshkov
Thomas Faber wrote: > I noticed a couple of tests structured like this: > > status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, > sizeof(contents), &offset, NULL); > ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see > below */, "exp

Asynchronous read/write tests in ntdll/tests/file.c

2013-09-18 Thread Thomas Faber
Hey Dmitry, I noticed a couple of tests structured like this: status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, sizeof(contents), &offset, NULL); ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below */, "expected STATUS_PENDING, got %#x\n&

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

2013-09-18 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > > --- a/dlls/ntdll/tests/file.c > > +++ b/dlls/ntdll/tests/file.c > > @@ -1985,6 +1985,22 @@ static void test_read_write(void) > > > > bytes = 0xdeadbeef; > > SetLastError(0xdeadbeef); > > +ret = ReadFile

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

2013-09-18 Thread Nikolay Sivov
On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote: --- dlls/ntdll/tests/file.c | 41 + 1 file changed, 41 insertions(+) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 120fdac..5ae605b 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls

Re: [PATCH 7/8] d3d9/tests: Add tests for block-based volume formats.

2013-09-17 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-17 11:39, schrieb Stefan Dösinger: > --- dlls/d3d9/tests/device.c | 340 > +++ 1 file changed, 340 > insertions(+) Fyi, I have equivalent tests for d3d8, the behavior is the same. -

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)

2013-09-16 Thread Alexandre Julliard
André Hentschel writes: > --- > dlls/kernel32/tests/file.c | 84 > ++ > 1 file changed, 84 insertions(+) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c &&

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)

2013-09-13 Thread Nikolay Sivov
On 9/13/2013 22:26, André Hentschel wrote: +if (!pCreateFile2) +{ +win_skip("CreateFile2 is missing\n"); +return; +} Should be skip() so it'll show up when running with wine. Not sure how important it is though.

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 2)

2013-09-13 Thread Nikolay Sivov
On 9/13/2013 22:26, André Hentschel wrote: Sorry, ignore my comment. I missed that we actually have this call already in wine.

Re: [PATCH 1/3] iphlpapi/tests: Increase buffer size to prevent overflow.

2013-09-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2158 Your par

Re: [PATCH 2/3] riched20/tests: Add UTF8 BOM tests for EM_SETTEXTEX. (try 5)

2013-09-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2155 Your par

Re: ntdll/tests: Fix compilation on systems that don't support nameless unions. (rediffed)

2013-09-13 Thread Dmitry Timoshkov
Francois Gouget wrote: > That tree was a bit out of date causing the patch to fail to apply. I > updated it and rediffed. I'd appreciate if you could postpone sending this sort of patches when they could conflict with other pending patches in that area. Thanks. -- Dmitry.

Re: ntdll/tests: Fix compilation on systems that don't support nameless unions.

2013-09-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2144 Your par

Re: d3d9/tests: D3DCMP_GREATER is broken on r500 (try 2).

2013-09-12 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2136 Your par

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-12 13:36, schrieb Henri Verbeet: > I really just meant the typo in the comment. Ah yes, that should be "distorted". -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmai

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Henri Verbeet
cted results when just comparing geometry Z vs geometry Z, so a > game that uses it and doesn't depend on a match with the clear value > should still work, maybe with reduced precision. > > D3DCMP_GREATEREQUAL has the same bug as D3DCMP_GREATER. > D3DCMP_LESSEQUAL works ok as wel

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Stefan Dösinger
k, maybe with reduced precision. D3DCMP_GREATEREQUAL has the same bug as D3DCMP_GREATER. D3DCMP_LESSEQUAL works ok as well. After two hours of trying to find out what the driver does I decided it's not worth the time and marked the tests broken. It is after all a no longer maintained Windows

Re: [PATCH 5/5] d3d9/tests: D3DCMP_GREATER is broken on r500.

2013-09-12 Thread Henri Verbeet
On 12 September 2013 12:23, Stefan Dösinger wrote: > + * On the r500 driver on Windows D3DCMP_GREATER and D3DCMP_GREATEREQUAL > are broken for depth > + * values > 0.5. The range appears to be distored, apparently an > incoming value of ~0.875 is "distorted"?

Re: ws2_32/tests: Add more WSASocket tests

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2126 Your par

Re: kernel32/tests: Add tests for ResolveDelayLoadedAPI (try3)

2013-09-11 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2121 Your par

riched20/tests: Add tests for ITextDocument_Save. (try 2)

2013-09-11 Thread Jactry Zeng
Update: Add todo_wine From 8f464b1ffa384ffba25af5041065c23d21ede041 Mon Sep 17 00:00:00 2001 From: Jactry Zeng Date: Wed, 11 Sep 2013 18:06:02 +0800 Subject: riched20/tests: Add tests for ITextDocument_Save. To: wine-patches Reply-To: wine-devel --- dlls/riched20/tests/richole.c | 102

Re: [PATCH 4/6] ws2_32: Add more WSADuplicateSocket tests

2013-09-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2063 Your par

Re: ntdll/tests: Add tests for job objects. (try 2)

2013-09-06 Thread Andrew Cook
On 06/09/13 17:12, Frédéric Delanoy wrote: > On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook wrote: >> --- >> dlls/ntdll/tests/Makefile.in | 1 + >> dlls/ntdll/tests/job.c | 151 >> +++ >> include/winnt.h

Re: ntdll/tests: Add tests for job objects. (try 2)

2013-09-06 Thread Frédéric Delanoy
On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook wrote: > --- > dlls/ntdll/tests/Makefile.in | 1 + > dlls/ntdll/tests/job.c | 151 > +++ > include/winnt.h | 5 ++ > 3 files changed, 157 insertions(+) > create m

Re: [PATCH 6/6] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2023 Your par

Re: ntdll/tests: Add tests for job objects.

2013-09-05 Thread Alexandre Julliard
Andrew Cook writes: > diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in > index 10d6674..1903d10 100644 > --- a/dlls/ntdll/tests/Makefile.in > +++ b/dlls/ntdll/tests/Makefile.in > @@ -11,6 +11,7 @@ C_SRCS = \ > file.c \ > generat

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Dmitry Timoshkov
leted immediately, the function > > > returns FALSE and the GetLastError function returns ERROR_IO_PENDING, > > > indicating that the operation is executing in the background." > > > > We have the tests for that, MSDN descriptions are proved to be often > &

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Wolfgang Walter
gt; "If the overlapped operation cannot be completed immediately, the function > > returns FALSE and the GetLastError function returns ERROR_IO_PENDING, > > indicating that the operation is executing in the background." > > We have the tests for that, MSDN descriptions are p

Re: [PATCH 3/5] ddraw/tests: Test DDCAPS2_TEXTUREMANAGE compatibility with other flags

2013-09-05 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2016 Your par

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Dmitry Timoshkov
the GetLastError function returns ERROR_IO_PENDING, > indicating that the operation is executing in the background." We have the tests for that, MSDN descriptions are proved to be often incorrect or incomplete. -- Dmitry.

Re: [PATCH 3/5] ddraw/tests: Test DDCAPS2_TEXTUREMANAGE compatibility with other flags

2013-09-05 Thread Stefan Dösinger
Oops, will resend later. Henri Verbeet schrieb: >On 5 September 2013 10:42, Stefan Dösinger >wrote: >> +if(DDSD->ddsCaps.dwCaps2 & DDSCAPS2_TEXTUREMANAGE) >Minor formatting error here. -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Wolfgang Walter
Am Donnerstag, 5. September 2013, 17:52:42 schrieb Dmitry Timoshkov: > Wolfgang Walter wrote: > > On Thursday 05 September 2013 10:42:40 you wrote: > > > Wolfgang Walter wrote: > > > > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: > > > > WaitCommEvent > > > > error %d\n", i, GetLa

Re: [PATCH 3/5] ddraw/tests: Test DDCAPS2_TEXTUREMANAGE compatibility with other flags

2013-09-05 Thread Henri Verbeet
On 5 September 2013 10:42, Stefan Dösinger wrote: > +if(DDSD->ddsCaps.dwCaps2 & DDSCAPS2_TEXTUREMANAGE) Minor formatting error here.

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Dmitry Timoshkov
Wolfgang Walter wrote: > On Thursday 05 September 2013 10:42:40 you wrote: > > Wolfgang Walter wrote: > > > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: WaitCommEvent > > > error %d\n", i, GetLastError()); +ok(res || (!res && > > > GetLastError() == ERROR_IO_PENDING), "%d

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-05 Thread Wolfgang Walter
On Thursday 05 September 2013 10:42:40 you wrote: > Wolfgang Walter wrote: > > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: WaitCommEvent > > error %d\n", i, GetLastError()); +ok(res || (!res && > > GetLastError() == ERROR_IO_PENDING), "%d: WaitCommEvent error %d\n", i, > >

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-04 Thread Dmitry Timoshkov
Wolfgang Walter wrote: > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: WaitCommEvent > error %d\n", i, GetLastError()); > +ok(res || (!res && GetLastError() == ERROR_IO_PENDING), "%d: > WaitCommEvent error %d\n", i, GetLastError()); This change looks spurious and unrelat

Re: [PATCH] wined3d: Fix per-stage constant in GLSL fixed function pipeline + add tests. (try 2)

2013-09-04 Thread Matteo Bruni
ted when needed. Tests > are also added. > > Thanks to Matteo Bruni for review and support. > > Try 2: > - update with latest git Hi, I have a few small nits still, please bear with me... > --- > dlls/d3d9/tests/visual.c | 80 >

  1   2   3   4   5   6   7   8   9   10   >