Re: [PATCH] svchost: Implementation of svchost (revised submission 2)

2007-11-28 Thread Alexandre Julliard
Roy Shea <[EMAIL PROTECTED]> writes: > This is another revised and standalone version of the svchost patch. > Changes in this revision include: > > - Only using HEAP_ZERO_MEMORY in calls to HeapReAlloc. Calls to > HeapAlloc explicitly set the NULL terminator when required. The realloc is overk

Re: [PATCH] svchost: Implementation of svchost (revised submission)

2007-11-27 Thread Roy Shea
On Tue, Nov 27, 2007 at 03:37:50PM -0600, James Hawkins wrote: > On Nov 27, 2007 3:21 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > > This is a revised and standalone version of svchost patch. Changes in > > this revision include: > > > > - Unicode based with a simple UNICODE to ASCII function used to

Re: [PATCH] svchost: Implementation of svchost (revised submission)

2007-11-27 Thread James Hawkins
On Nov 27, 2007 3:21 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > This is a revised and standalone version of svchost patch. Changes in > this revision include: > > - Unicode based with a simple UNICODE to ASCII function used to > convert the lpProcName passed into GetProcAddress > I think you're

Re: svchost: Implementation of svchost

2007-11-08 Thread Robert Shearman
Roy Shea wrote: > Changelog: > * Implementation of svchost > You've got a lot of global functions in this patch that should be static. -- Rob Shearman