Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes:
> + vi.dwOSVersionInfoSize = sizeof(vi);
> + GetVersionExW(&vi);
> +
> + /* On Windows 9x start does not have the process title argument.
> +It works such that if the first parameter begins with a double quote
> ("),
> +
On Wednesday 30 January 2008 04:52:33 Dmitry Timoshkov wrote:
> "Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote:
> > try 2 (thanks to Dmitry & Detlef)
> >
> > - Use GlobalFree instead of LocalFree
> > - Fix indentation
> > - Remove part of a comment
> >
> > try 3
> > - Use LocalFree, fixin
"Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote:
> try 2 (thanks to Dmitry & Detlef)
>
> - Use GlobalFree instead of LocalFree
> - Fix indentation
> - Remove part of a comment
>
> try 3
> - Use LocalFree, fixing CommandLineToargvW first
The following question from my original review stil
On Tuesday 29 January 2008 04:10:34 Dmitry Timoshkov wrote:
> "Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote:
> > - Use GlobalFree instead of LocalFree
>
> According to MSDN LocalFree is the correct one, as I asked before
> you need to fix Wine implementation of CommandLineToArgvW.
Sorry
"Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote:
> - Use GlobalFree instead of LocalFree
According to MSDN LocalFree is the correct one, as I asked before
you need to fix Wine implementation of CommandLineToArgvW.
--
Dmitry.
On Monday 28 January 2008 04:58:12 you wrote:
> "Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote:
> > + NOTE: This will only work when run from Wine's cmd, but
> > that's ok as start is a builtin + shell command on NT */
>
> What's the purpose of the comment above?
On So, 2008-01-27 at 21:18 +0100, Alexander Nicolaysen Sørnes wrote:
> SHELLEXECUTEINFOW sei;
> +OSVERSIONINFOW vi;
> WCHAR *args = NULL;
> - int i;
> + int i = 1;
>
The idention show a mismatch between SPACE and TAB
--
By by ... Detlef
"Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> wrote:
> + NOTE: This will only work when run from Wine's cmd, but that's ok
> as start is a builtin
> + shell command on NT */
What's the purpose of the comment above?
> +if(argc > 1 && (vi.dwMajorVersion >= 5
