[kernel32/console.c] A really very small fix.

2006-11-24 Thread Anatoly
Hi! This fix change CodePage parameter in MultiByteToWideChar() type function from CP_ACP to return of GetConsoleOutputCP(). Now unicode symbols correct outs in wineconsole application (ex: Far). Changelog: Change codepage parameter in ReadConsoleA function. Change codepage parameter in Scro

Re: WININET: small fix for InternetCreateUrlA

2005-11-04 Thread James Hawkins
On 11/4/05, Saulius Krasuckas <[EMAIL PROTECTED]> wrote: > This was a one minute looker, so it can contain some logical errors or so. > No it's good. I don't know why I got ERROR_ALREADY_EXISTS when I was testing, but I swear I did! I don't get the error anymore so it must have been leftover fro

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Alexandre Julliard
Felix Nawothnig <[EMAIL PROTECTED]> writes: > >> (IsBadWritePtr isn't the fastest thing in the world...) > > Just looked at the implementation - it does at most > (buflen-1)/pagesize+1 memory-references, and since buflen will be > MAX_PATH in most cases this just costs us the calling-overhead -

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Uwe Bonnes
> "Felix" == Felix Nawothnig <[EMAIL PROTECTED]> writes: >>> (IsBadWritePtr isn't the fastest thing in the world...) Felix> Just looked at the implementation - it does at most Felix> (buflen-1)/pagesize+1 memory-references, and since buflen will be Felix> MAX_PATH in most cases

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Felix Nawothnig
(IsBadWritePtr isn't the fastest thing in the world...) Just looked at the implementation - it does at most (buflen-1)/pagesize+1 memory-references, and since buflen will be MAX_PATH in most cases this just costs us the calling-overhead - which is worth the increased readability. -flx

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Felix Nawothnig
Andreas Mohr wrote: Does Win9x GetCurrentDirectoryA() really use an IsBadWritePtr to protect against invalid output buffers? Somehow I slightly doubt it... (IsBadWritePtr isn't the fastest thing in the world...) Well, no. Looking at the disassembly it does about this: static WINE_EXCEPTION_FIL

Re: Small fix for GetCurrentDirectoryA()

2005-06-10 Thread Andreas Mohr
Hi, On Fri, Jun 10, 2005 at 07:26:33AM +0200, Felix Nawothnig wrote: > This makes Yoda Stories (which is shipped with a broken wavmix32.dll) > run out of the box. > > ChangeLog: > When emulating Win9x return ERROR_INVALID_PARAMETER if a bad buffer is > passed to GetCurrentDirectoryA(). Does Win

Re: small fix SafeArryDestroy

2005-01-30 Thread Rob Shearman
Rein Klazes wrote: Hi, Makes WJChess, a French made chess game, accept moves. Changelog: dlls/oleaut32 : safearray.c SafeArrayDestroy() returns success when called with a NULL pointer. It would be nice to have a test for this as there are already a large number of SafeArray tests. Rob

Re: small fix

2004-10-04 Thread Mike Hearn
Hi, Hi! Here is a small patch for wine-20040914. Summary: tool window with a caption are not managed. This doesn't seem quite right - WS_EX_TOOLWINDOW & WS_CAPTION should be managed as we set the EWMH hints for this style later on in the code. What WM are you using Sergey? thanks -mike