On Monday 01 December 2003 20:33, Dimitrie O. Paun wrote:
> On December 1, 2003 03:26 pm, Alexandre Julliard wrote:
> > That's not possible, such a simple function cannot take 168us, unless
> > you have a 1Mhz CPU... How did you measure it?
>
> I think he measured it across the call:
>
> start
>
Andrew de Quincey <[EMAIL PROTECTED]> writes:
> CharNextW takes on average 168.5340us. However it is called 12396 times when
> opening the save box for IDA. As I said, IDA supplies quite a large string of
> filter expressions to the save box. This results in a total time of
> 2089146.9655us bei
On December 1, 2003 03:26 pm, Alexandre Julliard wrote:
> That's not possible, such a simple function cannot take 168us, unless
> you have a 1Mhz CPU... How did you measure it?
I think he measured it across the call:
start
CharNextW
end
but it still doesn't add up. If his measurement is c
On Monday 01 December 2003 09:32, Andrew de Quincey wrote:
> > In other words, I don't think the patch is acceptable. What I'd suggest:
> > -- figure out why the real CharNextA() is slow, and try to fix that
> > -- figure out why it takes so long to call CharNextW()
>
> As I said originally, it
> In other words, I don't think the patch is acceptable. What I'd suggest:
> -- figure out why the real CharNextA() is slow, and try to fix that
> -- figure out why it takes so long to call CharNextW()
As I said originally, its not that CharNextW/CharNextA are particularly slow,
its the numb
On Sunday 30 November 2003 01:23, Dimitrie O. Paun wrote:
> On November 29, 2003 06:27 pm, Andrew de Quincey wrote:
> > I've replaced the calls to CharNextA()/CharNextW() with array increments
> > and a local static function. This knocks 3.5 seconds off the file open
> > dialogue in IDA.
>
> Well,
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes:
> Well, I'm not sure this is worth doing. First off, we're not fixing any
> app that makes use of CharNext{A,W}(). Second, why is your static method
> any faster than the real CharNextA()? Third, it's not correct to replace
> CharNextW() with an array
On November 29, 2003 06:27 pm, Andrew de Quincey wrote:
> I've replaced the calls to CharNextA()/CharNextW() with array increments
> and a local static function. This knocks 3.5 seconds off the file open
> dialogue in IDA.
Well, I'm not sure this is worth doing. First off, we're not fixing any
app
