Re: (try 3) shlwapi: implement StrChrNW

2009-09-24 Thread Aric Stewart
Ah that is what i get for trying to rush to get this written before breakfast. try 4 coming. -aric Paul Vriens wrote: On 09/24/2009 02:19 PM, Aric Stewart wrote: includes test to show that MSDN is wrong and the search IS case-sensitive. thanks for all the comments. --- dlls/shlwapi/shlwa

Re: (try 3) shlwapi: implement StrChrNW

2009-09-24 Thread Paul Vriens
On 09/24/2009 02:19 PM, Aric Stewart wrote: includes test to show that MSDN is wrong and the search IS case-sensitive. thanks for all the comments. --- dlls/shlwapi/shlwapi.spec | 1 + dlls/shlwapi/string.c | 22 ++ dlls/shlwapi/tests/string.c | 22 ++ 3 fil

Re: (resend) shlwapi: implement StrChrNW

2009-09-24 Thread Aric Stewart
I will write up a conformance test to check. It should not be too hard. thanks, -aric Alexandre Julliard wrote: Aric Stewart writes: MSDN states that "The comparison is not case-sensitive" Considering that there is also a StrChrNIW, it's a pretty safe bet that MSDN is once again on crack.

Re: (resend) shlwapi: implement StrChrNW

2009-09-24 Thread Alexandre Julliard
Aric Stewart writes: > MSDN states that "The comparison is not case-sensitive" Considering that there is also a StrChrNIW, it's a pretty safe bet that MSDN is once again on crack. -- Alexandre Julliard julli...@winehq.org

Re: shlwapi: implement StrChrNW

2009-09-24 Thread Bruno Jesus
On Thu, Sep 24, 2009 at 00:32, Dmitry Timoshkov wrote: > "Aric Stewart" wrote: > >> +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) >> +{ >> +  TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch); >> + >> +  if (lpszStr) >> +  { >> +    ch = toupperW(ch); >> +    while

Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Paul Vriens
On 09/24/2009 04:04 AM, Aric Stewart wrote: MSDN states that "The comparison is not case-sensitive" -aric Jacek Caban wrote: Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec | 1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-)

Re: shlwapi: implement StrChrNW

2009-09-23 Thread Dmitry Timoshkov
"Aric Stewart" wrote: +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) +{ + TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch); + + if (lpszStr) + { +ch = toupperW(ch); +while (*lpszStr && cchMax > 0) +{ + if (toupperW(*lpszStr) == ch) +re

Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Aric Stewart
MSDN states that "The comparison is not case-sensitive" -aric Jacek Caban wrote: Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) I didn't test it myself, but St

Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Jacek Caban
Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) I didn't test it myself, but StrChrNW name suggests, that the search shouldn't be case insensitive. Jacek

Re: shlwapi: implement StrChrNW

2009-09-23 Thread Nikolay Sivov
Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) Maybe it's better to move this --- +@ stdcall StrChrNW(wstr long long) --- closer to context: --- @ stdcall StrChrA (str long)