Re: shellpath.c: Avoid copying invalid data on error

2004-10-22 Thread Juan Lang
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > - it doesn't add a break statement to the default > > case (some compilers warn on this) > > I seriously doubt that, what compiler does this for > you? MSVC at certain warning levels IIRC. But my memory is suspect. > > -WCHAR szBuil

Re: shellpath.c: Avoid copying invalid data on error

2004-10-22 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > The following is a better patch, I think, in that > - it doesn't add a break statement to the default case > (some compilers warn on this) I seriously doubt that, what compiler does this for you? It's much better practice to always add break to all cases,