Alexandre Julliard wrote:
There's no reason to reformat all of shell32. If a given function is
messed up you can fix it (in a separate patch), but otherwise it
doesn't really matter if all functions don't use the exact same style.
Proposal:
add source code formatting at check-in - with a twist.
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> This was no joke. If you say, you would accept such as reformating patch,
> I can easyly create one that eliminates all tab-characters, and generates
> nice and uniform indented code.
> This will make it a bit easier to create the small self-contained p
> > There are also a number of unneeded whitespace changes that make the
> > patch larger than it should be.
>
> Yes, I tried to make some functions I had to alter a bit more readable.
> What about running a pretty printer, for example astyle
> (http://astyle.sourceforge.net/)
> on the whole code
--- "Dimitrie O. Paun" <[EMAIL PROTECTED]> wrote:
> There is csgrep in the tools/ module in CVS, but for that
> to work you guys need to run our commit_prep and log_accum
> in CVSROOT. If you do that, you get the wine-cvs - type
> messages for free, and can use our patch.py script to
> generate pat
On January 12, 2004 09:14 am, Steven Edwards wrote:
> There has to be a more simple way of us diffing our patches. Would any
> of the scripts you use on Crossover merging help us?
There is csgrep in the tools/ module in CVS, but for that
to work you guys need to run our commit_prep and log_accum
i
Hiya M8,
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote:
> I know it's a pain, but the real solution for next time is to submit
> things as soon as they are done, instead of waiting a month and then
> sending a huge patch that cannot possibly be reviewed.
There has to be a more simple way of us
On 12.01.2004 01:41:45 Alexandre Julliard wrote:
> "Martin Fuchs" <[EMAIL PROTECTED]> writes:
>
> > Mhh - could you please tell me which "ugly hacks" you are speaking of?
>
> From a quick look at the patch, what I noticed is mostly the ifdefs
> and other various disabling/commenting out of parts
> I'm afraid you'll have to do that. There's no way I can put that patch
> in as is, it's way too big and doing way too many different things. It
> also has a number of ugly hacks that will have to be cleaned up.
> Please submit small self-contained patches that do only one thing,
> with a changelo
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> Yes, I am aware of that.
> This patch is the result of four weeks work (not only of me), spending
> most of the time with debugging, as most of those stuff is pretty
> undocumented by Microsoft. It's not possible to simply look at the
> ReactOS CVS hist
> Martin, sending a bunch of patches compressed and in one message,
> makes them almost unreviewable but by the most die hards readers
> of wine-patches. It also makes it so much more difficult for
> Alexandre to split them up, match the ChangeLog, review them, etc.
> Please stick to one-(uncompres
Sorry, I forgot to include the new file "shlcpanel.c" into the shell32 patch mail.
Changelog:
- Implementation of control panel folder in shgell namespace
--
Martin Fuchs
[EMAIL PROTECTED]
shlcpanel.patch
Description: Binary data
On January 11, 2004 08:04 am, Martin Fuchs wrote:
> This patch consists of a number of changes we implemented in the ReactOS
> CVS tree in order to use Wine's shell32.dll implementation for ReactOS
> explorer. Please see the following changelog lists for the individual patch
> descriptions:
Martin
12 matches
Mail list logo
