Hi,
I've made a small change in shell32.dll to enable one to type a
myfile.txt from Start->Run dialog (for example).
I've simply replaced the call to CreateProcess with ShellExecute.
I've tested this change in reactos and it works nicely.
It won't really work since there is something wrong with Sh
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> Changelog:
> _ILCreateFolder(), _ILCreateValue(): check for NULL in AlternateFileName
cAlternateFileName is an array, it cannot possibly be NULL.
--
Alexandre Julliard
[EMAIL PROTECTED]
> > /* process the IDList */
> > -if ((sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST)
> /*0x0c*/
> > +if (sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) /* 0x0c: includes
> SEE_MASK_IDLIST */
>
> If you only care about the MASK_IDLIST flag you should check just that
> flag
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> /* process the IDList */
> -if ((sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST) /*0x0c*/
> +if (sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) /* 0x0c: includes SEE_MASK_IDLIST */
If you only care about the MASK_IDLIST flag you s
Martin Fuchs wrote:
On 25.03.2004 22:31:59 Dimitrie O. Paun wrote:
On Thu, 25 Mar 2004, Martin Fuchs wrote:
OK, now the patch including the "return S_FALSE". :-)
This is why small patches are better than large ones :)
Mhh - if you had accepted the whole patch, I would not hav
On 25.03.2004 22:31:59 Dimitrie O. Paun wrote:
> On Thu, 25 Mar 2004, Martin Fuchs wrote:
>
> > OK, now the patch including the "return S_FALSE". :-)
>
> This is why small patches are better than large ones :)
Mhh - if you had accepted the whole patch, I would not have
forgotten to include this
On Thu, 25 Mar 2004, Martin Fuchs wrote:
> OK, now the patch including the "return S_FALSE". :-)
This is why small patches are better than large ones :)
--
Dimi.
On 25.03.2004 01:00:25 Alexandre Julliard wrote:
> "Martin Fuchs" <[EMAIL PROTECTED]> writes:
>
> > + if (This->bDirty)
> > + return S_OK;
> > +
> > return NOERROR;
>
> S_OK and NOERROR mean the same thing, so this doesn't look quite
> right.
Sure. It should be S_FALSE instead of NOE
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> + if (This->bDirty)
> + return S_OK;
> +
> return NOERROR;
S_OK and NOERROR mean the same thing, so this doesn't look quite
right.
--
Alexandre Julliard
[EMAIL PROTECTED]
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> + /* Add double quotation marks unless we already have them
> (e.g.: "%1" %* for exefile) */
> + if (res != out && *(res - 1) == '"')
> + {
> + strcpyW(res, cmd);
> +
"Martin Fuchs" <[EMAIL PROTECTED]> writes:
> Alexandre - is there any thing wrong with this patch?
Yes there has to be something wrong, you create a sei_tmp structure
but you never actually use it. I'm not sure what your intent was.
--
Alexandre Julliard
[EMAIL PROTECTED]
Alexandre - is there any thing wrong with this patch?
> Changelog:
> - expand environment strings in command, parameter and directory strings of
> ShellExecuteExW32()
My follow-up patches are blocked by this not yet committed patch.
Martin Fuchs wrote:
I see you found and could solve the problem.
If I understand correctly, this says, this part of IE installation uses PIDLs,
which are illegal in some way?
Is this the normal behaviour or only result of for example some
mis-convifured registry entries?
Actually, I added the ERR(
Hello,
> > This patch broke the installation of IE6.
> >
> > When running the command below during installation of IE6, a pathname is
> > scribbled over the stack...
> >
> > C:\windows\inf\unregmp2.exe /Shortcuts /IE5 /RegExts
> >
> > Any ideas why?
I see you found and could solve the problem
This patch broke the installation of IE6.
When running the command below during installation of IE6, a pathname is
scribbled over the stack...
C:\windows\inf\unregmp2.exe /Shortcuts /IE5 /RegExts
Any ideas why?
Mike
Martin Fuchs wrote:
This patch is based on work of Ge van Geldorp <[EMAIL PRO
Dmitry Timoshkov wrote:
"Jakob Eriksson" <[EMAIL PROTECTED]> wrote:
Depending on how you define break, that argument can be used to stop
almost any patch to Wine, if the goal happens to be cross compilation.
What way will you decide to go, if in the next Platform SDK release
Microsoft wil
Dmitry Timoshkov wrote:
"Rolf Kalbermatter" <[EMAIL PROTECTED]> wrote:
I was under the impression that it was desirable to cross compile as many
dlls as possible in different environments.
Yes, that's a desirable task, but only if does not require to break Wine
source accomplishing it.
"Jakob Eriksson" <[EMAIL PROTECTED]> wrote:
> Depending on how you define break, that argument can be used to stop
> almost any patch to Wine, if the goal happens to be cross compilation.
What way will you decide to go, if in the next Platform SDK release
Microsoft will remove some of the existin
"Rolf Kalbermatter" <[EMAIL PROTECTED]> wrote:
> I was under the impression that it was desirable to cross compile as many
> dlls as possible in different environments.
Yes, that's a desirable task, but only if does not require to break Wine
source accomplishing it.
> shell32 has currently only
"Steven Edwards" <[EMAIL PROTECTED]> wrote:
> Well I would agree with you if it was just not defined in Mingw but
> there is nothing we can do about getting Microsoft to add it to the
> PSDK. If we want to build/test on MS_VC what are we to do?
Microsoft provided headers and libraries usually mis
"Dmitry Timoshkov" <[EMAIL PROTECTED]>
>"Martin Fuchs" <[EMAIL PROTECTED]> wrote:
>
>> > > Changelog:
>> > > - don't link directly to NTDLL; use MultiByteToWideChar() instead of
>> > RtlCreateUnicodeStringFromAsciiz()
>> >
>> > Why do you need that?
>>
>> RtlCreateUnicodeStringFromAsciiz() is ne
Hi Dmitry,
--- Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> > RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor
> in PSDK.
>
> That doesn't justify the change IMO. There are lots of places in Wine
> using that construct, and it's much more convenient and avoids code
> duplication
"Martin Fuchs" <[EMAIL PROTECTED]> wrote:
> > > Changelog:
> > > - don't link directly to NTDLL; use MultiByteToWideChar() instead of
> > RtlCreateUnicodeStringFromAsciiz()
> >
> > Why do you need that?
>
> RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK.
That doesn'
> > Changelog:
> > - don't link directly to NTDLL; use MultiByteToWideChar() instead of
> RtlCreateUnicodeStringFromAsciiz()
>
> Why do you need that?
RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK.
Regards,
Martin
"Martin Fuchs" <[EMAIL PROTECTED]> wrote:
> Changelog:
> - don't link directly to NTDLL; use MultiByteToWideChar() instead of
> RtlCreateUnicodeStringFromAsciiz()
Why do you need that?
--
Dmitry.
Changelog:
- implemented SHGetRealIDL()
Index: pidl.c
===
RCS file: /home/wine/wine/dlls/shell32/pidl.c,v
retrieving revision 1.96
diff -u -p -d -r1.96 pidl.c
--- pidl.c 18 Jan 2004 22:08:46 - 1.96
+++ pidl.c 20 Ja
OK. Relatively to files shlexec.c (ShellExecute, etc) I will do it. Others
with you ;)
- Original Message -
From: "Steven Edwards" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Friday, January 16, 2004 2:15 PM
Subject: Re: Shell3
This patch replaces the prior patch. The ReactOS changelog wasnt very
good and Martin pointed out that I missed the spec file.
Changelog:
"Martin Fuchs" <[EMAIL PROTECTED]>
Implement RestartDialog and RestartDialogEx
__
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Sig
28 matches
Mail list logo
