> From: Ilya Basin
>
> Then postponing till my next slack period, the more so I got another
> e-mail:
>
> === W7PROX64 (32 bit shlexec) ===
> No test failures found
>
> === W7PROX64 (64 bit shlexec) ===
>
> shell32:
> shlexec.c:1609: Test failed: ShellExecuteEx(null,
> "C:\Users\winetest\AppData\
PV> Hi Ilya,
PV> In your last email on wine-devel about this subject you mentioned adding
PV> some extra tests. There was at least some communication with you and the
PV> author of that piece you are now removing. The reason for that piece was
PV> shown in a code-snippet he gave and adding test
On 04/24/2010 10:53 AM, Ilya Basin wrote:
1) removes the block of code that splits lpFile into filename and
parameters and removes '"'s from filename . Even without this block
ShellExecute not fails with quoted lpFile.
2) removes 2 corresponding todo_wine's from tests.
The real application affe
On 4/24/2010 12:53, Ilya Basin wrote:
1) removes the block of code that splits lpFile into filename and
parameters and removes '"'s from filename . Even without this block
ShellExecute not fails with quoted lpFile.
2) removes 2 corresponding todo_wine's from tests.
The real application affected
PV> The only thing I'm wondering is why this big piece was added in the
PV> first place (2004) but that in itself is of course no guarantee it was
PV> needed.
PV> Is it possible to create more tests or is everything possible already
PV> catered for by that one test?
Add a new verb that has '%*' i
On 03/22/2010 07:59 AM, Ilya Basin wrote:
Hi! Sorry for being annoying, will you accept my patch?
http://www.winehq.org/pipermail/wine-patches/2010-March/086009.html
Hi Ilya,
That's not up to us.
Whenever you sent a patch to wine-patch everybody is free to comment (or
sent a reply that they
Hi! Sorry for being annoying, will you accept my patch?
http://www.winehq.org/pipermail/wine-patches/2010-March/086009.html
--
2010/3/18 Ilya Basin :
> PV> If this is no longer a todo_wine you should change the filename_tests
> PV> struct:
> You're right.
>
> Do you have any clue why this block of code was added to
> SHELL_execute() ?
>
>
try git blame and see if the commit message is of any help...
PV> If this is no longer a todo_wine you should change the filename_tests
PV> struct:
You're right.
Do you have any clue why this block of code was added to
SHELL_execute() ?
On 03/17/2010 04:21 PM, Ilya Basin wrote:
@@ -1013,7 +1011,7 @@ static void test_filename(void)
"%s failed: rc=%d err=%d\n", shell_call,
rc, GetLastError());
}
-else todo_wine
+else
{
ok(rc==test->rc, "%s failed:
10 matches
Mail list logo
