Re: try 2: shell32: fix SHFileOperation copying to an empty file list

2008-06-01 Thread James Hawkins
On Sun, Jun 1, 2008 at 1:35 AM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > This partially fixex bug 13394. > > Apparently there are two separate issues involved in that bug, one > with empty destination lists (which Windows seems to treat as a list > containing one 0-length string), and one involv

Re: shell32: fix SHFileOperation copying to an empty file list

2008-05-31 Thread James Hawkins
On Sat, May 31, 2008 at 8:56 PM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > OK, I'll add the test for FO_MOVE. > > On Sat, May 31, 2008 at 9:52 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> What does that have to do with this fix? You don't talk about it in >> your email, changelog, or the code

Re: shell32: fix SHFileOperation copying to an empty file list

2008-05-31 Thread Vincent Povirk
OK, I'll add the test for FO_MOVE. On Sat, May 31, 2008 at 9:52 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > What does that have to do with this fix? You don't talk about it in > your email, changelog, or the code. It's part of truncating to 8.3 format. The extension can't be longer than 3 cha

Re: shell32: fix SHFileOperation copying to an empty file list

2008-05-31 Thread James Hawkins
On Sat, May 31, 2008 at 8:47 PM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > Grr, forgot to copy list. > > -- Forwarded message -- > From: Vincent Povirk <[EMAIL PROTECTED]> > Date: Sat, May 31, 2008 at 9:46 PM > Subject: Re: shell32: fix SHFileOper

Fwd: shell32: fix SHFileOperation copying to an empty file list

2008-05-31 Thread Vincent Povirk
Grr, forgot to copy list. -- Forwarded message -- From: Vincent Povirk <[EMAIL PROTECTED]> Date: Sat, May 31, 2008 at 9:46 PM Subject: Re: shell32: fix SHFileOperation copying to an empty file list To: James Hawkins <[EMAIL PROTECTED]> On Sat, May 31, 2008 at 9:

Re: shell32: fix SHFileOperation copying to an empty file list

2008-05-31 Thread James Hawkins
On Sat, May 31, 2008 at 8:10 PM, Vincent Povirk <[EMAIL PROTECTED]> wrote: > On Windows, copying files to an empty file list copies each file to > the working directory, truncating each filename to 8.3 format. See bug > 13394. > > I'm not very happy about the way I implemented this (a special loop