Re: shell32: Write-strings warning fix

2006-06-07 Thread Andrew Talbot
Andrew Talbot wrote: > Robert Shearman wrote: >> Sorry, this is wrong. If InsertMenuItemA writes to the string then it >> will be corrupted and will display the wrong thing for further uses in >> the process. > > A MENUITEMINFOA's dwTypeData is currently declared as writeable (LPSTR); > what it i

Re: shell32: Write-strings warning fix

2006-06-07 Thread Andrew Talbot
Robert Shearman wrote: > Sorry, this is wrong. If InsertMenuItemA writes to the string then it > will be corrupted and will display the wrong thing for further uses in > the process. A MENUITEMINFOA's dwTypeData is currently declared as writeable (LPSTR); what it is initialised from will not affec

Re: shell32: Write-strings warning fix

2006-06-07 Thread Robert Shearman
Andrew Talbot wrote: Changelog: shell32: Write-strings warning fix. diff -urN a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c --- a/dlls/shell32/shlview.c2006-05-23 17:24:50.0 +0100 +++ b/dlls/shell32/shlview.c2006-06-07 19:37:41.0 +0100 @@ -779,7 +779,9