Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

2010-07-22 Thread Alexandre Julliard
David Hedberg writes: > + > +/* Check that all the messages received can be found in > vista_plus_msgs. */ > +#define verify_vista_plus_msgs()\ > +do {\ > +UINT

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

2010-07-18 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3459 Your paranoid android.

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)

2010-07-18 Thread David Hedberg
On Sun, Jul 18, 2010 at 3:10 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://test

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.

2010-07-17 Thread Nikolay Sivov
On 7/17/2010 21:20, David Hedberg wrote: Thanks for the pointers, I'll see if I can expand the tests somewhat and send a new version, probably simply using the local SetStyle helper (unless the tests shows something really weird). I realized that probably not all modes could be supported with v5

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.

2010-07-17 Thread David Hedberg
On Sat, Jul 17, 2010 at 5:51 PM, Nikolay Sivov wrote: >  On 7/17/2010 19:45, David Hedberg wrote: >> >> On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov >>  wrote: >>> >>>  On 7/17/2010 19:08, David Hedberg wrote:  static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UI

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.

2010-07-17 Thread Nikolay Sivov
On 7/17/2010 19:45, David Hedberg wrote: On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov wrote: On 7/17/2010 19:08, David Hedberg wrote: static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT mode) { - IShellViewImpl *This = impl_from_IFolderView(iface); - F

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.

2010-07-17 Thread David Hedberg
On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov wrote: >  On 7/17/2010 19:08, David Hedberg wrote: >> >>  static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT >> mode) >>  { >> -       IShellViewImpl *This = impl_from_IFolderView(iface); >> -       FIXME("(%p)->(%u), stub\n", Th

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.

2010-07-17 Thread Nikolay Sivov
On 7/17/2010 19:08, David Hedberg wrote: static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT mode) { - IShellViewImpl *This = impl_from_IFolderView(iface); - FIXME("(%p)->(%u), stub\n", This, mode); - return E_NOTIMPL; +IShellViewImpl *This = im