shell32: Implement IDD_MAKENEWFOLDER

2009-03-27 Thread Jonathan Armond
Hi This implements the make new folder button for the SHBrowseForFolders dialog. It's my first patch, so I'm asking for comments. Note, renaming of the new folder is still not supported. Jon --- dlls/shell32/brsfolder.c | 46 +++--- 1 files changed,

Re: shell32: Implement IDD_MAKENEWFOLDER.

2009-03-26 Thread Juan Lang
Hi John, a few problems with this one: -{ +{ This whitespace-only change isn't needed for your patch, please omit it. +if (info->pidlRet == NULL) +return FALSE; +{ This is poor style, IMHO. Surely an explicit else would be better than the implicit else block here? +