Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread Juan Lang
> ^ is bitwise-XOR, so it is more like if(This->navpane.show != show_navpane), > which looks to be what he intended. Ah, yes 'tis. Perhaps it's a deficiency of my brain, but when reading bit-twiddling code, I remember the bitwise operators, but when reading logical code, I tend to stick to the bo

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread David Hedberg
On Thu, Aug 26, 2010 at 19:32, Octavian Voicu wrote: > On Thu, Aug 26, 2010 at 8:11 PM, Juan Lang wrote: >> Hi David, I know this was committed already, but something caught my >> eye that I didn't understand: >> >> +    if(This->navpane.show ^ show_navpane) >> >> Is this a cute way to write if(T

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread Octavian Voicu
On Thu, Aug 26, 2010 at 8:11 PM, Juan Lang wrote: > Hi David, I know this was committed already, but something caught my > eye that I didn't understand: > > +    if(This->navpane.show ^ show_navpane) > > Is this a cute way to write if(This->navpane.show && show_navpane) ? > If so, why ^ rather tha

Re: shell32: Add a navigation pane to the ExplorerBrowser control.

2010-08-26 Thread Juan Lang
Hi David, I know this was committed already, but something caught my eye that I didn't understand: +if(This->navpane.show ^ show_navpane) Is this a cute way to write if(This->navpane.show && show_navpane) ? If so, why ^ rather than &&? Thanks, --Juan