Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2283 Your paranoid android.

RE: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread Greg Geldorp
Hi David, > From: David Hedberg [mailto:david.hedb...@gmail.com] > > I applied the patch generated by the testbot on top of master, and > both an ordinary build and a crosstest build seems to complete fine > for me. Am I missing something, or is the problem located elsewhere? It's possible that

Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread David Hedberg
On Mon, May 24, 2010 at 2:40 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://test

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread Nikolay Sivov
On 5/24/2010 17:13, David Hedberg wrote: You don't test for a rectangle later, so there's no point to initialize it. I haven't written any tests to see what ::Initialize can handle yet, but the reasoning behind the initialization is to make sure that ExplorerBrowser won't crash randomly du

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread David Hedberg
On Mon, May 24, 2010 at 2:42 PM, Nikolay Sivov wrote: > On 5/24/2010 16:25, David Hedberg wrote: > > Hi, David. >> >> +} >> + >> +static ULONG WINAPI IExplorerBrowser_fnRelease(IExplorerBrowser *iface) >> +{ >> +    ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface; >> +    TRACE("This: %p\n

Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2280 Your paranoid android.

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2278 Your paranoid android.

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.

2010-05-24 Thread Nikolay Sivov
On 5/24/2010 16:25, David Hedberg wrote: Hi, David. +} + +static ULONG WINAPI IExplorerBrowser_fnRelease(IExplorerBrowser *iface) +{ +ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface; +TRACE("This: %p\n", This); + +This->ref--; +TRACE("Ref: %d\n", This->ref); Use inte