Re: setupapi - ReactOS Merge 20050205

2005-02-12 Thread Steven Edwards
> That's why the version checks are unnecessary. Apps that check the > version won't use these functions anyway, and apps that don't check > will just work. There's no point at all in adding extra checks to > deliberately break a function, unless of course an app really depends > on the broken beha

Re: setupapi - ReactOS Merge 20050205

2005-02-09 Thread Alexandre Julliard
Steven Edwards <[EMAIL PROTECTED]> writes: > --- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > You shouldn't do that kind of preventive version check, you should > > always call the function and then deal with failures appropriately. > > Sorry I am a little dense. If both functions are just n

Re: setupapi - ReactOS Merge 20050205

2005-02-08 Thread Steven Edwards
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > You shouldn't do that kind of preventive version check, you should > always call the function and then deal with failures appropriately. Sorry I am a little dense. If both functions are just no-ops on Win9x then the app should not be calling th

Re: setupapi - ReactOS Merge 20050205

2005-02-08 Thread Alexandre Julliard
Steven Edwards <[EMAIL PROTECTED]> writes: > +BOOL WINAPI DelayedMove(LPCWSTR lpExistingFileName, LPCWSTR lpNewFileName) > +{ > +if (OsVersionInfo.dwPlatformId != VER_PLATFORM_WIN32_NT) > +{ > +SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > +return FALSE; > +} > + > +r