Re: setupapi: Implement pSetupGetField, with tests.

2008-03-27 Thread James Hawkins
On Thu, Mar 27, 2008 at 10:52 AM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > >> What's the reason for checking the HeapFree here? Or what's the reason > for doing > >> it at all? > >> > > > > To show that the value returned is not in the hea

Re: setupapi: Implement pSetupGetField, with tests.

2008-03-27 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: >> What's the reason for checking the HeapFree here? Or what's the reason for >> doing >> it at all? >> > > To show that the value returned is not in the heap. Isn't any of HeapValidate or HeapSize better in that case? -- Dmitry.

Re: setupapi: Implement pSetupGetField, with tests.

2008-03-27 Thread James Hawkins
On Thu, Mar 27, 2008 at 7:06 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi James, > > I'm looking into a crash of the setupapi/parser test on Vista. > > It crashes in this piece: > > 465 ret = HeapFree( GetProcessHeap(), 0, (LPVOID)field ); > 466 ok( !ret, "Expected HeapFree

Re: setupapi: Implement pSetupGetField, with tests.

2008-03-27 Thread Paul Vriens
Hi James, I'm looking into a crash of the setupapi/parser test on Vista. It crashes in this piece: 465 ret = HeapFree( GetProcessHeap(), 0, (LPVOID)field ); 466 ok( !ret, "Expected HeapFree to fail\n" ); 467 ok( GetLastError() == ERROR_INVALID_PARAMETER, 468