Re: server/protocol.def documentation

2005-03-10 Thread Juan Lang
--- Alexandre Julliard <[EMAIL PROTECTED]> wrote: > protocol.def itself is the documentation of the protocol, there is no > need for more. It's pretty much self-explaining anyway, and people who > can't figure it out by reading the code have no business messing > around with the server protocol. Co

Re: server/protocol.def documentation

2005-03-10 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > As far as documenting the server API, again I agree with you: it's a > worthwhile task. There's even a todo list item for it assigned to > Alexandre.. but I wouldn't hold my breath for him to provide something > parseable by newbies. protocol.def itself is

Re: server/protocol.def documentation

2005-03-09 Thread Mike McCormack
James Hawkins wrote: I guess it's not so much that I can't understand it when I read through the code and read the comments, but that we should document this so whoever needs to work with the server next won't have to take time to read through the necessary files to understand it. It's not comment

Re: server/protocol.def documentation

2005-03-09 Thread Juan Lang
Hi James, > ie why we use do...while(0) loops in SERVER_START_REQ This is a fairly common idiom in C macros. See here for an explanation: http://www.everything2.com/index.pl?node_id=1180050 Because it's a common trick, I'm not sure it's worth explaining. Describing at a high level what SERVER_

Re: server/protocol.def documentation

2005-03-09 Thread James Hawkins
On Wed, 09 Mar 2005 18:55:43 +, Mike Hearn <[EMAIL PROTECTED]> wrote: > There are no docs, AFAIK, but I found the file pretty self explanatory > when I read it. Which bits do you find confusing? Maybe we can document > only those parts. I guess it's not so much that I can't understand it when

Re: server/protocol.def documentation

2005-03-09 Thread Mike Hearn
There are no docs, AFAIK, but I found the file pretty self explanatory when I read it. Which bits do you find confusing? Maybe we can document only those parts.

Re: server/protocol.def documentation

2005-03-08 Thread James Hawkins
On Wed, 9 Mar 2005 07:34:16 +0100, Marcus Meissner <[EMAIL PROTECTED]> wrote: > On Tue, Mar 08, 2005 at 06:38:01PM -0600, James Hawkins wrote: > > Hi, > > > > I now understand the purpose of SERVER_START_REQ et al, but now I'm in > > server/protocol.def and I'm trying to add a protocol definition f

Re: server/protocol.def documentation

2005-03-08 Thread Marcus Meissner
On Tue, Mar 08, 2005 at 06:38:01PM -0600, James Hawkins wrote: > Hi, > > I now understand the purpose of SERVER_START_REQ et al, but now I'm in > server/protocol.def and I'm trying to add a protocol definition for > load_key. load_key is implemented in server/registry.c, but is not in > server/pr

server/protocol.def documentation

2005-03-08 Thread James Hawkins
Hi, I now understand the purpose of SERVER_START_REQ et al, but now I'm in server/protocol.def and I'm trying to add a protocol definition for load_key. load_key is implemented in server/registry.c, but is not in server/protocol.def so, if I'm correct, I can't make a call to load_key from ntdll y