Re: [PATCH 2/2] secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Piotr Caban
Hi, On 09/14/10 20:53, Henri Verbeet wrote: Personally I thought Mikko's series was nicer, not in the least for actually having tests. (Though I don't think it's good to have a dependency on mail.google.com.) I didn't know about Mikko's patches. I find his patches better then mine (more complet

Re: secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Piotr Caban
Hi, On 09/14/10 20:52, Juan Lang wrote: -TRACE("context_handle %p, message %p, message_seq_no %d, quality %p\n", +FIXME("context_handle %p, message %p, message_seq_no %d, quality %p\n", Did you intend to leave this change in? Yes, this functions is very incomplete. It for example lacks

Re: [PATCH 2/2] secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Henri Verbeet
On 14 September 2010 20:28, Piotr Caban wrote: > --- >  dlls/secur32/schannel.c |   30 -- >  1 files changed, 20 insertions(+), 10 deletions(-) > Personally I thought Mikko's series was nicer, not in the least for actually having tests. (Though I don't think it's good t

Re: secur32: Reorganize data returned by schan_DecryptMessage.

2010-09-14 Thread Juan Lang
Hi Piotr, -TRACE("context_handle %p, message %p, message_seq_no %d, quality %p\n", +FIXME("context_handle %p, message %p, message_seq_no %d, quality %p\n", Did you intend to leave this change in? --Juan