Re: secur32: Getting real functionality into the NTLM provider

2005-08-24 Thread Alexandre Julliard
Kai Blin <[EMAIL PROTECTED]> writes: > * Alexandre Julliard <[EMAIL PROTECTED]> [23/08/05, 20:39:52]: > >> You should avoid using stdio. > > How would I do this avoiding stdio? ntlm_auth uses stdin and stdout to > read input and write output. This seems to be the Unix way of doing > things. I mea

Re: secur32: Getting real functionality into the NTLM provider

2005-08-23 Thread Kai Blin
* Alexandre Julliard <[EMAIL PROTECTED]> [23/08/05, 20:39:52]: Thanks for the comments. I see you points in all of them, apart from the following one, where I didn't understand what you meant. > > +{ > > +helper->pipe_in = fdopen(pipe_in[0], "r"); > > +close(pipe_in[1]); > > +

Re: secur32: Getting real functionality into the NTLM provider

2005-08-23 Thread Alexandre Julliard
Kai Blin <[EMAIL PROTECTED]> writes: > +unsigned char buffer[SECUR32_MAX_BUF_LEN+6000]; > +BYTE bin[SECUR32_MAX_BUF_LEN]; You shouldn't allocate fixed size buffers on the stack, especially not huge ones like that. You should compute the necessary size and allocate a proper