On 24/04/07, James Hawkins <[EMAIL PROTECTED]> wrote:
On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote:
> On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote:
> >
> >
>
> +if (LsaVersion != 0x1)
>
> What is 0x1? If it's not defined in the SDK, then please use a
> #define to clarify
On 24/04/07, James Hawkins wrote:
Can you resend the patch with the value #defined?
Sure, the last thing I wish to do is ignore review. It should be in
your mailbox now.
You actually implicitly found a bug in my tests, which also wrongly
made me drop an older version of the implementation just
On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote:
On 24/04/07, James Hawkins <[EMAIL PROTECTED]> wrote:
> On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote:
> > On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote:
> > >
> > >
> >
> > +if (LsaVersion != 0x1)
> >
> > What is 0x1? If
On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote:
On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote:
>
>
+if (LsaVersion != 0x1)
What is 0x1? If it's not defined in the SDK, then please use a
#define to clarify what it means.
Also, it would be nice to have some tests for the
On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote:
+if (LsaVersion != 0x1)
What is 0x1? If it's not defined in the SDK, then please use a
#define to clarify what it means.
--
James Hawkins
