Re: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam

2007-05-07 Thread Detlef Riekenberg
On Mo, 2007-05-07 at 18:29 +0200, Mounir IDRASSI wrote: > Thanks for your reply. I'm rewriting the patches and sending them back. > > Mounir IDRASSI > IDRIX - Cryptography and IT Security Experts > http://www.idrix.fr > > Detlef Riekenberg wrote: > > I have no Idea about the code, but the missing

Re: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam

2007-05-07 Thread Mounir IDRASSI
Thanks for your reply. I'm rewriting the patches and sending them back. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Detlef Riekenberg wrote: > I have no Idea about the code, but the missing defines should > be a seperate patch. > > Your idention looks broken. >

Re: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam

2007-05-07 Thread Detlef Riekenberg
On Sa, 2007-05-05 at 19:16 +0200, Mounir IDRASSI wrote: > --- a/include/wincrypt.h > +++ b/include/wincrypt.h > +/* Values returned by CryptGetProvParam of PP_KEYSTORAGE */ > +#define CRYPT_SEC_DESCR 0x0001 > +#define CRYPT_PSTORE0x0002 > +#define CRYPT_UI_PROMPT

Re: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam

2007-05-06 Thread Mounir IDRASSI
MAIL PROTECTED]> Date: Sun, 6 May 2007 21:36:08 +0200 Subject: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam --- dlls/rsaenh/rsaenh.c | 32 ++- dlls/rsaenh/tests/rsaenh.c | 61 --- include/wincrypt.h

Re: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam

2007-05-05 Thread Maarten Lankhorst
Mounir IDRASSI schreef: > We have found few bugs in the MS Enhanced CSP implementation in wine > (rsaenh.dll) and you'll find attached a patch that corrects them. Hello Mounir, Bug fixes are always welcome in wine. But fixing bugs is one thing, but it is also very recommended to add tests to verif

rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam

2007-05-05 Thread Mounir IDRASSI
<[EMAIL PROTECTED]> Date: Sat, 5 May 2007 19:01:57 +0200 Subject: rsaenh: fix bugs in RSAENH_CPAcquireContext and RSAENH_CPGetProvParam --- dlls/rsaenh/rsaenh.c | 32 +++- include/wincrypt.h |5 + 2 files changed, 36 insertions(+), 1 deletions(-) diff --git