Re: riched20: explicitly cast WPARAM to character types

2011-10-24 Thread Thomas Faber
Hi Michael, On 2011-10-23 21:25, Michael Stefaniuc wrote: > On 10/22/2011 10:38 PM, Thomas Faber wrote: >> This makes the use of casts more consistent and shows the conversion >> from WPARAM to CHAR/WCHAR is intentional for WM_CHAR/EM_SETPASSWORDCHAR. >> Also fixes two MSVC warnings. > To make it

Re: riched20: explicitly cast WPARAM to character types

2011-10-23 Thread David Laight
On Sun, Oct 23, 2011 at 09:25:26PM +0200, Michael Stefaniuc wrote: > > No clue anyway why MSVC even warns, integer to integer conversions are > allowed. ... Generally better to turn off MSVC's over-pedantic warnings about integer conversions. Using casts for integer convertions can actually hide

Re: riched20: explicitly cast WPARAM to character types

2011-10-23 Thread Michael Stefaniuc
On 10/22/2011 10:38 PM, Thomas Faber wrote: > This makes the use of casts more consistent and shows the conversion > from WPARAM to CHAR/WCHAR is intentional for WM_CHAR/EM_SETPASSWORDCHAR. > Also fixes two MSVC warnings. To make it consistent remove the WCHAR cast 3 lines above. Casts are *not* th