Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
Can you explain what benefits can we get from merging these two tests? To me it only make them hard to read. 2013/7/18 Nikolay Sivov : > On 7/19/2013 00:15, Caibin Chen wrote: >> >> What files do you mean to merge? txtsrv.c and richole.c or >> test/richole.c and test/richole.c? > > Tests of course

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/19/2013 00:15, Caibin Chen wrote: What files do you mean to merge? txtsrv.c and richole.c or test/richole.c and test/richole.c? Tests of course. Another solution is to create ITextService instance in richole.c and run range tests or whatever tests you need on it. It's a couple of lines to

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
What files do you mean to merge? txtsrv.c and richole.c or test/richole.c and test/richole.c? 2013/7/18 Nikolay Sivov : > On 7/19/2013 00:04, Caibin Chen wrote: >> >> The ITextRange objects are returned by ITextDocument_Range() method. >> Both IRichEditOle and ITextService supports ITextDocument i

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/19/2013 00:04, Caibin Chen wrote: The ITextRange objects are returned by ITextDocument_Range() method. Both IRichEditOle and ITextService supports ITextDocument interface. Currently we don't have ITextDocument support in ITextService. my another patch[1] is to add ITextDocument interface sup

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
The ITextRange objects are returned by ITextDocument_Range() method. Both IRichEditOle and ITextService supports ITextDocument interface. Currently we don't have ITextDocument support in ITextService. my another patch[1] is to add ITextDocument interface support in ITextService. [1]. http://www.wi

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/18/2013 23:36, Caibin Chen wrote: ITextRange will be used in both richole.c and txtsrv.c. I'm planning to add more tests in it. I think it makes more sense to have one test file for each interface, which improves the readability of tests. That's usually done for implementation, but not for t

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Caibin Chen
ITextRange will be used in both richole.c and txtsrv.c. I'm planning to add more tests in it. I think it makes more sense to have one test file for each interface, which improves the readability of tests. 2013/7/18 Nikolay Sivov : > On 7/18/2013 20:28, Caibin Chen wrote: >> >> Add tests for start

Re: riched20: Add tests for ITextRange interface.

2013-07-18 Thread Nikolay Sivov
On 7/18/2013 20:28, Caibin Chen wrote: Add tests for start and end point, setting and getting text. --- dlls/riched20/tests/Makefile.in | 3 +- dlls/riched20/tests/txtrng.c| 343 2 files changed, 345 insertions(+), 1 deletion(-) create mode 100