Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-21 Thread Vit Hrachovy
On Wed, May 16, 2007 at 06:41:33PM +0200, Frank Richter wrote: > > just add all > > "preset" memory sizes, and WM_SETTEXT the value read from the registry. > > Might be code-wise a bit simpler than your GETCURSEL approach, but > otherswise not much different I think. > > -f.r. Hi Frank, I've sim

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Frank Richter
On 16.05.2007 18:18, Frank Richter wrote: > I would make the combobox editable (plain CBS_DROPDOWN), Er, you do that already. Pays off to read... > just add all > "preset" memory sizes, and WM_SETTEXT the value read from the registry. Might be code-wise a bit simpler than your GETCURSEL approac

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Frank Richter
I would make the combobox editable (plain CBS_DROPDOWN), just add all "preset" memory sizes, and WM_SETTEXT the value read from the registry. -f.r.

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Laurent Vromman
It is not really as I wish. I have just noticed that there is two different kind of indentation in the mentioned switch loop, which looked strange on the moment. I am really not a wine master, others will maybe fixed us. Laurent On Wed, 16 May 2007 15:59:06 +0200, Vit Hrachovy <[EMAIL PROTECT

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Vit Hrachovy
On Wed, May 16, 2007 at 03:18:22PM +0200, Laurent Vromman wrote: > case CBN_SELCHANGE: { > SendMessage(GetParent(hDlg), PSM_CHANGED, 0, 0); > switch (LOWORD(wParam)) { > - case IDC_D3D_VSHADER_MODE: > on_d3d_vshader_mode_changed(hDl

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Laurent Vromman
case CBN_SELCHANGE: { SendMessage(GetParent(hDlg), PSM_CHANGED, 0, 0); switch (LOWORD(wParam)) { - case IDC_D3D_VSHADER_MODE: on_d3d_vshader_mode_changed(hDlg); break; - } +case IDC_D3D_VSHA

review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-05-16 Thread Vit Hrachovy
Hi, the attached patch adds new editable combobox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. I've tried to implement Frank's comments to English language only. Please consider this patch as a proposal, so if it gets positive review, I'll propagate the changes to all remaining

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-04-27 Thread Frank Richter
On 27.04.2007 09:23, Vit Hrachovy wrote: > Hi, > the attached patch adds new textbox input 'Video Memory size' for > Graphics/Direct3D tab of winecfg. Updated every live locale resource to > include this. Some thoughts on the UI: - Maybe make it an editable combobox with common sizes in the dropdo

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-04-27 Thread Vit Hrachovy
On Fri, Apr 27, 2007 at 12:14:47PM +0200, Stefan Dösinger wrote: > On a quick look I see a number of whitespace issues in the patch. in the .rc > files you are using tabs while the rest of the code uses spaces at some > places, in other lines you're using spaces yourself. In the code you add some

Re: review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-04-27 Thread Stefan Dösinger
Am Freitag 27 April 2007 09:23 schrieb Vit Hrachovy: > Hi, > the attached patch adds new textbox input 'Video Memory size' for > Graphics/Direct3D tab of winecfg. Updated every live locale resource to > include this. > > Adding this option was discussed on thread 'More Direct3D settings in > winecf

review: add Video Memory text input to winecfg Graphics/Direct3D tab

2007-04-27 Thread Vit Hrachovy
Hi, the attached patch adds new textbox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. Updated every live locale resource to include this. Adding this option was discussed on thread 'More Direct3D settings in winecfg (was: Enabling GLSL in winecfg)' at wine-devel. changelog entry