Re: regedit: consistent formatting

2003-12-08 Thread Dimitrie O. Paun
On December 9, 2003 12:43 am, Shachar Shemesh wrote: > On the contrary. I said that, except for Dimi (who doesn't like > attachments), everyone WERE interested. I was interested as well, it's just that I prefer inline patches rather than text/plain attachments. But if Alexandre likes attachments

Re: regedit: consistent formatting

2003-12-08 Thread Shachar Shemesh
Geoff Thorpe wrote: On December 8, 2003 03:58 pm, Shachar Shemesh wrote: Lionel Ulmer wrote: 2) or even better, write a re-tabulator which produce source code following THE RULES (tool that would be applied to all source code on each commit). So it's certainly possible to have it working :

Re: regedit: consistent formatting

2003-12-08 Thread Geoff Thorpe
On December 8, 2003 03:58 pm, Shachar Shemesh wrote: > Lionel Ulmer wrote: > > 2) or even better, write a re-tabulator which produce source code > > following THE RULES (tool that would be applied to all source code on > > each commit). > > > >So it's certainly possible to have it working :-) > > >

Re: regedit: consistent formatting

2003-12-08 Thread Steven Edwards
--- Shachar Shemesh <[EMAIL PROTECTED]> wrote: > And that was a non-controversial change (well, Dimi objected, IIRC. > Like > I said). There was a perl script that Patrik wrote the do the conversion of the whole Winehq source tree. We should really just run this script once a year or something. A

Re: regedit: consistent formatting

2003-12-08 Thread Shachar Shemesh
Lionel Ulmer wrote: but this is still not feasible because a lot of people touch the code, and even the same person touches it using different editors, from different boxes, etc. How are you going to make sure everyone has their editors setup just so (if at all possible!)? Face it, there's no way

Re: regedit: consistent formatting

2003-12-08 Thread Lionel Ulmer
On Mon, Dec 08, 2003 at 12:30:57PM -0800, Alexandre Julliard wrote: > If I have to enforce a rule, the rule will be: no tabs allowed > whatsoever. So be careful what you wish for ;-) Well, this would really be the best solution I think. At 'real' work we have a no-TAB rule and it's the only real

Re: regedit: consistent formatting

2003-12-08 Thread Alexandre Julliard
Lionel Ulmer <[EMAIL PROTECTED]> writes: > Of course we can : we have a nice quality gate called 'Alexandre' which > commits all the patches. So we just need to, either : > > 1) write a tool that checks the source code for correct tabbing and rejects > the patch if it does not follow THE RULE

Re: regedit: consistent formatting

2003-12-08 Thread Dimitrie O. Paun
On December 8, 2003 02:52 pm, Lionel Ulmer wrote: > 1) write a tool that checks the source code for correct tabbing and > rejects the patch if it does not follow THE RULES Again, not feasible -- I for one edit wine stuff from multiple boxes, multiple editors, I don't want to have to learn how to

Re: regedit: consistent formatting

2003-12-08 Thread Lionel Ulmer
> but this is still not feasible because a lot of people touch the code, > and even the same person touches it using different editors, from different > boxes, etc. How are you going to make sure everyone has their editors > setup just so (if at all possible!)? Face it, there's no way it can > wor

Re: regedit: consistent formatting

2003-12-08 Thread Dimitrie O. Paun
On December 8, 2003 01:09 pm, Lionel Ulmer wrote: > Just to flame a bit (the lists were a bit quiet lately) : the only sane way > to dealing with TABs is when TABs are used properly (ie by an editor that > uses them only to go to the current C indenting level and uses spaces for > everything that c

Re: regedit: consistent formatting

2003-12-08 Thread Lionel Ulmer
On Mon, Dec 08, 2003 at 12:03:00AM -0500, Dimitrie O. Paun wrote: > Only whitespace changes. Unfortunately, the formatting was > all messed up by having tabs of 4 and 8 chars (I said it > before, and I'll say it again: the only sane way of dealing > with tabs is to always use the standard size of 8