Re: regedit: adding confirmation message before importing from file

2011-08-19 Thread Nowres Rafid
On Wed, 2011-08-17 at 08:19 -0700, Dan Kegel wrote: > On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote: > > Hi Nowres, > > did you run the regedit tests, > > cd programs/regedit/tests > > make test > > after that change? Here it fails with > > regedit.c:384: Test failed: regedit not availabl

Re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Nowres Rafid
On 17/08/2011 15:19, Dan Kegel wrote: On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote: Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at

Re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Dan Kegel
On Wed, Aug 17, 2011 at 8:17 AM, Dan Kegel wrote: > Hi Nowres, > did you run the regedit tests, >   cd programs/regedit/tests >   make test > after that change?  Here it fails with >  regedit.c:384: Test failed: regedit not available, skipping regedit tests > ( log at http://buildbot.kegel.com/bui

re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Dan Kegel
Hi Nowres, did you run the regedit tests, cd programs/regedit/tests make test after that change? Here it fails with regedit.c:384: Test failed: regedit not available, skipping regedit tests ( log at http://buildbot.kegel.com/builders/runtests/builds/2 ) You might need to fully implement th

Re: regedit: adding confirmation message before importing from file

2011-08-17 Thread Andrew Eikum
On Wed, Aug 17, 2011 at 12:24:18PM +, Nowres Rafid wrote: > -reg_file = fopen(realname, "r"); > + > + reg_file = fopen(realname, "r"); The file uses spaces for indenting. Please be consistent and don't use tabs. This is true elsewhere, to