Re: TaskDialog implementation

2011-06-15 Thread Jeff Latimer
On 11/06/11 17:45, Hans Leidekker wrote: > On Fri, 2011-06-10 at 23:29 -0500, Vincent Povirk wrote: >> Well, I think you may be right that changing it to E_NOTIMPL at this >> point would break something and might be a bad idea. Sadly, Hans >> didn't say what the stub was originally for. Hopefully,

Re: TaskDialog implementation

2011-06-11 Thread André Hentschel
Am 11.06.2011 09:45, schrieb Hans Leidekker: > On Fri, 2011-06-10 at 23:29 -0500, Vincent Povirk wrote: >> Well, I think you may be right that changing it to E_NOTIMPL at this >> point would break something and might be a bad idea. Sadly, Hans >> didn't say what the stub was originally for. Hopeful

Re: TaskDialog implementation

2011-06-11 Thread Hans Leidekker
On Fri, 2011-06-10 at 23:29 -0500, Vincent Povirk wrote: > Well, I think you may be right that changing it to E_NOTIMPL at this > point would break something and might be a bad idea. Sadly, Hans > didn't say what the stub was originally for. Hopefully, we'll soon > have a working implementation and

Re: TaskDialog implementation

2011-06-10 Thread Vincent Povirk
> On 06/09/11 10:55, Vincent Povirk wrote: >> +    if (pnButton) *pnButton = IDYES; >> +    if (pnRadioButton) *pnRadioButton = pTaskConfig->nDefaultButton; >> +    if (pfVerificationFlagChecked) *pfVerificationFlagChecked = TRUE; >> +    return S_OK; >> >> I don't think it's appropriate to make se

Re: TaskDialog implementation

2011-06-10 Thread Patrick Gauthier
(Sorry for the late reply. BSD dev machine had some hard disk issues.) Thanks for all your input. Here are some comments: On 06/09/11 10:51, Juan Lang wrote: > The patch was marked as "Pending." That usually means Alexandre's > waiting for something, e.g. for you to fix something obvious, or to

re: TaskDialog implementation

2011-06-09 Thread Dan Kegel
Patrick wrote: > I'd like to port my re-implementation of task dialogs > (http://www.korosoft.net/projects/tdemu/) to WINE Awesome! > I would like to have some guidance ... [Why was my patch from > yesterday not accepted?] An iota of guidance was provided at http://source.winehq.org/patches/ Scr

Re: TaskDialog implementation

2011-06-09 Thread Vincent Povirk
+if (pnButton) *pnButton = IDYES; +if (pnRadioButton) *pnRadioButton = pTaskConfig->nDefaultButton; +if (pfVerificationFlagChecked) *pfVerificationFlagChecked = TRUE; +return S_OK; I don't think it's appropriate to make selections for the user like this. If you can't present all of

Re: TaskDialog implementation

2011-06-09 Thread Juan Lang
Hi Patrick, > As this is quite a big amount of work, I would like to have some > guidance (what must I do to be sure it is accepted) so that I do not end > up doing all that for nothing - starting by knowing why my patch from > yesterday was not accepted (what did I do wrong). The patch was marke

Re: TaskDialog implementation

2011-06-09 Thread Lats
I have been looking at this and my advice is start simple and establish the basic framework ie. display a frame with a title. Then add functions and text items or buttons types one by one. Add complexity to the functions after the basic form is accepted. On 09/06/11 17:00, Patrick Gauthier wrot