Re: Add d3drmdef.h header file - try 4

2007-03-23 Thread Dmitry Timoshkov
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: Fix the D3DRMAPI definitions (Dimitry's Comments) Fix the inclusion of d3dtypes.h (Francois' Comments) Where other comments has gone, into a black hole? Changelog Add d3drmdef.h header file, required for d3drm implementation

Re: Add d3drmdef.h header - try 2

2007-03-13 Thread Vijay Kiran Kamuju
Hi, Please ignore the this one. I am sending a new one. I wrongly named the header file, effects of late night coding bye, VJ On 3/13/07, Francois Gouget <[EMAIL PROTECTED]> wrote: On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: > Changelog > --- > Add minimalistic d3drmdef.h > > ex

Re: Add d3drmdef.h header - try 2

2007-03-13 Thread Francois Gouget
On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: > Changelog > --- > Add minimalistic d3drmdef.h > > extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, > LPD3DVECTOR); Two nitpicks: Wine's headers usually don't specify extern (it's implicit). If there's a large lis

re: Add d3drmdef.h header - try 2

2007-03-12 Thread Dan Kegel
Vijay wrote: Add minimalistic d3drmdef.h But why? None of the code in wine currently needs it. Maybe you should submit it together with the first bit of code that needs it. -- Wine for Windows ISVs: http://kegel.com/wine/isv

Re: Add d3drmdef.h header

2007-03-12 Thread Vijay Kiran Kamuju
Hi, I have sent the fix for the problematic file, which I used a base. There a bug in bugzilla 7386 (http://bugs.winehq.org/show_bug.cgi?id=7386) , which needs implementation of D3DRM's vector functions. These are pure math functions. I am improving the fix given in bugzilla 7442 (http://bugs.win

Re: Add d3drmdef.h header

2007-03-12 Thread Dmitry Timoshkov
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > +#ifndef __D3DRMDEFS_H__ > +#define __D3DRMDEFS_H__ I saw d3dtypes.h and other d3d header files, its defined like this only, no wine prefix has been added. No, it's not defined like this. That's exactly how microsoft does it, this is not ho

Re: Add d3drmdef.h header

2007-03-12 Thread Vijay Kiran Kamuju
Hi On 3/12/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: "Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > I thought for completeness, we provide the entire header. > I did write all that with the help DirectX SDK. (Phew It took me 3 hrs > to type it) If it ends up as an almost exact copy of

Re: Add d3drmdef.h header

2007-03-12 Thread Dmitry Timoshkov
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) If it ends up as an almost exact copy of a microsoft header it's not worth an effort. +#ifndef __D3DRM

Re: Add d3drmdef.h header

2007-03-12 Thread Vijay Kiran Kamuju
Hi, I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) Thanks, VJ On 3/12/07, Dan Kegel <[EMAIL PROTECTED]> wrote: vijay wrote: > [complete d3drmdef.h] It seems premature to check that in without any cod

re: Add d3drmdef.h header

2007-03-12 Thread Dan Kegel
vijay wrote: [complete d3drmdef.h] It seems premature to check that in without any code that uses it. Also, did you really write all that yourself? - Dan