Re: [PATCH] buffer overflow checking for string functions

2008-09-07 Thread Marcus Meissner
On Fri, Sep 05, 2008 at 10:44:50PM +0100, Rob Shearman wrote: > 2008/9/5 Francois Gouget <[EMAIL PROTECTED]>: > > I have a few other concerns here: > > * Why do we need a macro here? I thought it was so that > > __builtin_object_size() could do its work, but the strcpy() functions > > above in

Re: [PATCH] buffer overflow checking for string functions

2008-09-05 Thread Rob Shearman
2008/9/5 Francois Gouget <[EMAIL PROTECTED]>: > I have a few other concerns here: > * Why do we need a macro here? I thought it was so that > __builtin_object_size() could do its work, but the strcpy() functions > above in the patch have no associated macro and they call > __builtin_object_s

Re: [PATCH] buffer overflow checking for string functions

2008-09-05 Thread Francois Gouget
On Thu, 4 Sep 2008, Marcus Meissner wrote: [...] > +#if defined(__GNUC__) && (__GNUC__ < 4) > +# define __builtin_object_size(x,y) -1 > +#endif Shouldn't this be: #if !defined(__GNUC__) || (__GNUC__ < 4) To preserve compatibility with non-GNU compilers. > +static inline INT > +WINAPI MultiB

Re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Marcus Meissner
On Thu, Sep 04, 2008 at 11:34:43AM -0700, Dan Kegel wrote: > Hi Marcus, > http://kegel.com/wine/patchwatcher/results/ shows your patch seems > to have caused a test to fail. The full log is at > http://kegel.com/wine/patchwatcher/results/1045.log > Can you check it and see if it's spurious, or if

re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Dan Kegel
Hi Marcus, http://kegel.com/wine/patchwatcher/results/ shows your patch seems to have caused a test to fail. The full log is at http://kegel.com/wine/patchwatcher/results/1045.log Can you check it and see if it's spurious, or if this is something you need to fix up, or if it was a lurking bug? Tha

Re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Marcus Meissner
On Thu, Sep 04, 2008 at 05:37:45PM +0100, Rob Shearman wrote: > 2008/9/4 Marcus Meissner <[EMAIL PROTECTED]>: > > +#ifndef STATUS_STACK_BUFFER_OVERRUN > > +# define STATUS_STACK_BUFFER_OVERRUN 0xC409 > > +#endif > > +#ifndef EH_NONCONTINUABLE > > +# define EH_NONCONTINUABLE 0x01 > > +#endi

Re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Rob Shearman
2008/9/4 Marcus Meissner <[EMAIL PROTECTED]>: > +#ifndef STATUS_STACK_BUFFER_OVERRUN > +# define STATUS_STACK_BUFFER_OVERRUN 0xC409 > +#endif > +#ifndef EH_NONCONTINUABLE > +# define EH_NONCONTINUABLE 0x01 > +#endif These defines are not used. Either use them or remove them, but I would r