Re: rasapi32: return an error for invalid paramaters

2008-06-25 Thread Austin English
On Wed, Jun 25, 2008 at 12:12 PM, Juan Lang <[EMAIL PROTECTED]> wrote: > Hi Austin, at the risk of getting flamed for discussing elementary C > here I'll give some feedback. Appreciate the help. I don't have any C experience, so this testcase was hacked together by looking at a few other testcases

Re: rasapi32: return an error for invalid paramaters

2008-06-25 Thread Juan Lang
Hi Austin, at the risk of getting flamed for discussing elementary C here I'll give some feedback. +static void test_rasenum(void) +{ + +BOOL result; + Indentation and whitespace are a little funny here. + LPRASDEVINFO = sizeof(RASDEVINFO); This is a little confused. You've named a type

Re: rasapi32: return an error for invalid paramaters

2008-06-25 Thread Austin English
On Tue, Jun 24, 2008 at 4:55 PM, Austin English <[EMAIL PROTECTED]> wrote: > On Tue, Jun 24, 2008 at 3:55 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> On Tue, Jun 24, 2008 at 3:47 PM, Austin English <[EMAIL PROTECTED]> wrote: >>> >> >> Changes like these are so simple that you really should go t

Re: rasapi32: return an error for invalid paramaters

2008-06-24 Thread Austin English
On Tue, Jun 24, 2008 at 3:55 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Tue, Jun 24, 2008 at 3:47 PM, Austin English <[EMAIL PROTECTED]> wrote: >> > > Changes like these are so simple that you really should go the extra 5 > feet and write simple tests for them. > > -- > James Hawkins > I ha

Re: rasapi32: return an error for invalid paramaters

2008-06-24 Thread James Hawkins
On Tue, Jun 24, 2008 at 3:47 PM, Austin English <[EMAIL PROTECTED]> wrote: > Changes like these are so simple that you really should go the extra 5 feet and write simple tests for them. -- James Hawkins