Re: qcap: Fix compilation on systems that have v4l1 but not VIDIOCMCAPTURE & co.

2013-03-06 Thread Alexandre Julliard
Francois Gouget writes: > In particular this fixes compilation on FreeBSD 8.1. > > configure | 74 > +++ > configure.ac| 18 +++++ > dlls/qcap/v4l.c |4 +-- > include/config.h.in |3 +

Re: qcap: Fix compilation on older systems.

2013-01-18 Thread Francois Gouget
generally the wrong approach. Instead a test for the present of one of the VIDIOCS* defines would be better. However V4L is used in two places in qcap, only one of which needs these. So it should probably be done separately from the V4L check. > Want to get a patch in before the 1.4.2 re

Re: qcap: Fix compilation on older systems.

2013-01-18 Thread Damjan Jovanovic
On Fri, Jan 18, 2013 at 4:45 AM, Francois Gouget wrote: > On Tue, 15 Jan 2013, Damjan Jovanovic wrote: > >> What does this patch do? libv4l1.h includes libv4l1-videodev.h which >> is a copy of linux/videodev.h. You should only need the one or the >> other. Are you saying there is a system where li

Re: qcap: Fix compilation on older systems.

2013-01-17 Thread Francois Gouget
On Tue, 15 Jan 2013, Damjan Jovanovic wrote: > What does this patch do? libv4l1.h includes libv4l1-videodev.h which > is a copy of linux/videodev.h. You should only need the one or the > other. Are you saying there is a system where libv4l1.h is present but > incomplete, and you need to include li

Re: qcap: Fix compilation on older systems.

2013-01-15 Thread Dmitry Timoshkov
Damjan Jovanovic wrote: > What does this patch do? libv4l1.h includes libv4l1-videodev.h which > is a copy of linux/videodev.h. You should only need the one or the > other. Are you saying there is a system where libv4l1.h is present but > incomplete, and you need to include linux/videodev.h toget

Re: qcap: Fix compilation on older systems.

2013-01-15 Thread Damjan Jovanovic
On Tue, Jan 15, 2013 at 6:47 AM, Dmitry Timoshkov wrote: > --- > dlls/qcap/v4l.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/qcap/v4l.c b/dlls/qcap/v4l.c > index f5baaeb..2562c48 100644 > --- a/dlls/qcap/v4l.c > +++ b/dlls/qcap/v4l.c >

qcap patch

2012-03-16 Thread Christian Costa
Forget my qcap patch. It's the wrong one and I need to add missing CLSID defines in some headers first.

Qcap questions

2006-11-09 Thread Andrew Talbot
In qcap/pin.c, the function OutputPin_GetDeliveryBuffer() shows the parameters tStart and tStop as being of type const REFERENCE_TIME *. Looking at the SDK web site, I see a function called CBaseOutputPin::GetDeliveryBuffer() that has similar parameters that are non-const. May I deconstify these

RE: qcap/avicap and driver models

2005-05-24 Thread Rolf Kalbermatter
d about to many conditional compilation macros to support the different possible APIs (if any, I'm only a little bit familiar with v4l) > 2/ the driver shall be a driver for both avicap and qcap DLL As far as I can see it, this is also exactly as Windows does it. The VfWCaptureFilter real

Re: qcap/avicap and driver models

2005-05-22 Thread Eric Pouech
Maarten Lankhorst a écrit : Hi Alexandre, I implemented a driver model in qcap now, but avicap32 still uses my old #ifdef LINUX_VIDEODEV_H, since some people might be interested in writing capcreatecapturewindow, I think we should move out the drivers from qcap to our own vfwwine dll/driver

qcap/avicap and driver models

2005-05-21 Thread Maarten Lankhorst
Hi Alexandre, I implemented a driver model in qcap now, but avicap32 still uses my old #ifdef LINUX_VIDEODEV_H, since some people might be interested in writing capcreatecapturewindow, I think we should move out the drivers from qcap to our own vfwwine dll/driver, windows uses a similar model

Re: [QCAP] Final patch

2005-05-20 Thread Alexandre Julliard
Maarten Lankhorst <[EMAIL PROTECTED]> writes: > + > + if (!S_ISCHR (st.st_mode)) { > + ERR("%s: Not a device\n", device); > + CoTaskMemFree(capBox); > + return E_FAIL; > + } > > > > >Same here. > > > No, /dev/video* should never be an ordinary file,

Re: [QCAP] Final patch

2005-05-20 Thread Maarten Lankhorst
Dimi Paun wrote: On Fri, 2005-05-20 at 12:26 +0200, Maarten Lankhorst wrote: What do you suggest then ... fprintf(stderr? Absolutely not. :) But there are other options available: TRACE/WARN/FIXME. There's also MESSAGE, but it should be used *very* little. Also remember that most people wil

Re: [QCAP] Final patch

2005-05-20 Thread Dimi Paun
On Fri, 2005-05-20 at 12:26 +0200, Maarten Lankhorst wrote: > What do you suggest then ... fprintf(stderr? Absolutely not. :) But there are other options available: TRACE/WARN/FIXME. There's also MESSAGE, but it should be used *very* little. Also remember that most people will not see MESSAGE()s a

Re: [QCAP] Final patch

2005-05-20 Thread Dimi Paun
On Fri, 2005-05-20 at 10:37 +0200, Andreas Mohr wrote: > > > + ERR("Tinkerer detected? Thou shalt not define HAVE_V4L2 > \n"); > > > + CoTaskMemFree(capBox); > > > + close(capBox->fd); > > > + return E_FAIL; > > > > This is a FIXME. > It's not. His comments indicate that he has

Re: [QCAP] Final patch

2005-05-20 Thread Andreas Mohr
Hi, On Thu, May 19, 2005 at 09:20:25PM -0400, Dimi Paun wrote: > On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote: > > + > > + capBox->fd = open(device, O_RDWR | O_NONBLOCK); > > + if (capBox->fd == -1) { > > + ERR("%s: Failed to open: %s\n", device, strerror(errno)); > > +

Re: [QCAP] Final patch

2005-05-20 Thread Maarten Lankhorst
um, which causes it not to rescan for devices. The NATIVE version does, and since that gets installed by internet explorer, it's used. In that case, most of the errors I described shouldn't happen, because if it happens, something REALLY weird is going on... avicap runs the same stuff and

Re: [QCAP] Final patch

2005-05-19 Thread Dimi Paun
On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote: > m3h, v4l driver for vfwcapture.. please leave the ERR notice on > initialisation intact, thank you :) I think you've overusing ERR(). ERR() should be called to signal an internal error such as inconsistent state, not something that the

Re: [QCAP] patch 3, Adding enumMediaType object

2005-05-11 Thread Christian Costa
Robert Shearman wrote: Rolf Kalbermatter wrote: Changelog - dlls/qcap/Makefile.in - dlls/qcap/qcap_main.h dlls/qcap/enummedia.c Add IEnumMediaType object for use by other class objects. This is taken from quartz with only minor adaptions. We should be putting these files into a

Re: [QCAP] patch 3, Adding enumMediaType object

2005-05-10 Thread Robert Shearman
Rolf Kalbermatter wrote: Changelog - dlls/qcap/Makefile.in - dlls/qcap/qcap_main.h dlls/qcap/enummedia.c Add IEnumMediaType object for use by other class objects. This is taken from quartz with only minor adaptions. We should be putting these files into a static library that we

Re: [QCAP] patch 4, Adding enumPins object

2005-05-10 Thread Paul Vriens
> Changelog > - dlls/qcap/Makefile.in > - dlls/qcap/enumpins.c > Add IEnumPins object for use by other class objects. This is taken > from quartz with only minor adaptions. > > Rolf Kalbermatter > > > +WINE_DEFAULT_DEBUG_CHANNEL(quartz); Shouldn't that be qcap ? Cheers, Paul.

qcap

2005-05-09 Thread Maarten Lankhorst
this is my qcap dll in its current state, because i dont have much time in the next couple of weeks I' d thought I'd post it, perhaps someone can make it work with the new qcap dll implementation, what i have here is a pretty much complete version of qcap + a near complete versi