Re: please help with patch submission

2006-07-31 Thread Neil Skrypuch
Clearly it was too early for me when I wrote that. I had counted the GUID length wrong (as 39 instead of 38), so the - 3 didn't make sense either. - Neil

Re: please help with patch submission

2006-07-31 Thread Damjan Jovanovic
--- Neil Skrypuch <[EMAIL PROTECTED]> wrote: > On Monday, July 31, 2006 06:37, Damjan Jovanovic > wrote: > > +WCHAR > guidStringWithBraces[MAX_GUID_STRING_LEN]; > > You need MAX_GUID_STRING_LEN + 1 to store the null > too, if I'm not mistaken. 0 1 2 3 01234567890123

Re: please help with patch submission

2006-07-31 Thread Neil Skrypuch
On Monday, July 31, 2006 06:37, Damjan Jovanovic wrote: > +    WCHAR guidStringWithBraces[MAX_GUID_STRING_LEN]; You need MAX_GUID_STRING_LEN + 1 to store the null too, if I'm not mistaken. > +CopyMemory(&guidStringWithBraces[1], lpGuidString, > +(MAX_GUID_STRING_LEN - 3) * sizeof(WCHA

please help with patch submission

2006-07-31 Thread Damjan Jovanovic
Hi I have a short patch that fixes serious bugs I've encountered in setupapi's SetupDiOpenClassRegKeyExW(). It's been mailed twice to wine-patches and is attached for reference. Is there anything wrong with it? Please comment. Thank you Damjan __