Re: pdh: check for NULL pointer reference

2007-10-22 Thread Jeff Latimer
>> In this case the fix is for a Null reference as indicated in the >> accompanying tests. The test prangs in the current build and the patch >> for pdh_main.c fixes the behaviour on XP. As I said, I can't tell if it >> > > How can a fix to pdh_main.c (which is Wine's implementation) fix

Re: pdh: check for NULL pointer reference

2007-10-22 Thread Hans Leidekker
On Monday 22 October 2007 13:15:57 Jeff Latimer wrote: > In this case the fix is for a Null reference as indicated in the > accompanying tests. The test prangs in the current build and the patch > for pdh_main.c fixes the behaviour on XP. As I said, I can't tell if it How can a fix to pdh_ma

Re: pdh: check for NULL pointer reference

2007-10-22 Thread Jeff Latimer
> > I don't think we want to emulate the broken XP behaviour of requiring a > buffer, even when querying the buffer size. Apps written to comply with > this behaviour should work on the current implementation. And MSDN mentions > only XP, which implies that it has been fixed in Win2k3 and up. In t

Re: pdh: check for NULL pointer reference

2007-10-22 Thread Hans Leidekker
On Monday 22 October 2007 11:30:10 Jeff Latimer wrote: > This function has specific XP behaviour which I have tested but I have > not been able to verify that Win2k etc works the same. Any comment welcome. I don't think we want to emulate the broken XP behaviour of requiring a buffer, even when