Re: patch to fix bug 8246

2008-03-11 Thread Hin-Tak Leung
I did wonder what the padding was about (it didn't do any harm...) - I'll be happy to rework it to make it acceptable. --- Andrey Turkin <[EMAIL PROTECTED]> wrote: > This is not about embedded nulls, this is about possibly not null terminated > strings. If there is zero somewhere in the buffer t

Re: patch to fix bug 8246

2008-03-11 Thread Andrey Turkin
This is not about embedded nulls, this is about possibly not null terminated strings. If there is zero somewhere in the buffer then we should only convert string up to that zero; if there isn't any nulls, then we have to convert full string and null-terminate string. This can be coded prettier, tho

Re: patch to fix bug 8246

2008-03-11 Thread Alexandre Julliard
Hin-Tak Leung <[EMAIL PROTECTED]> writes: > This is the fix to bug 8246 to get HtmlHelpW to work correctly. > It was first worked on by Andrey Turkin and updated later by me. Please add a proper log entry describing the change. > -static inline LPWSTR strdupAtoW(LPCSTR str) > +static inline L