Re: Fyi patch submission information on wiki updated for GitHub

2010-07-20 Thread Misha Koshelev
On Mon, 2010-07-19 at 22:48 -0600, Vitaliy Margolen wrote: > On 07/19/2010 08:59 PM, Misha Koshelev wrote: > > Unfortunately, the more intuitive > > git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old > > > > does not seem to result in patches that can be properly applied onto a > > diff

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-20 Thread Misha Koshelev
On Mon, 2010-07-19 at 22:48 -0600, Vitaliy Margolen wrote: > On 07/19/2010 08:59 PM, Misha Koshelev wrote: > > Unfortunately, the more intuitive > > git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old > > > > does not seem to result in patches that can be properly applied onto a > > diff

Re: Fyi patch submission information on wiki updated for GitHub

2010-07-19 Thread Vitaliy Margolen
On 07/19/2010 08:59 PM, Misha Koshelev wrote: Unfortunately, the more intuitive git format-patch -k --stdout HEAD~79..HEAD~78> /tmp/patch.old does not seem to result in patches that can be properly applied onto a different (upstream) remote (see below). Works fine here. You must have had some

Fyi patch submission information on wiki updated for GitHub

2010-07-19 Thread Misha Koshelev
My apologies, but it seems that only such a convoluted shell script seems to achieve the correct results for different remotes: http://wiki.winehq.org/GitWine#head-3fe70b8c0310e61d94ba30fe7edf19bd0630e1ef If anyone has a simpler solution, I can definitely update. Unfortunately, the more intuitiv

Re: Quick multiple-patch submission question

2010-01-28 Thread Henri Verbeet
On 29 January 2010 00:28, Juan Lang wrote: >> When submitting multiple patches that apply to the same component but >> each patch is unrelated (ie. each one fixes a different issue), is it >> still appropriate to label the patches with the [PATCH X/Y] notation? >> In the case I have at hand the pa

Re: Quick multiple-patch submission question

2010-01-28 Thread Michael Stefaniuc
On 01/29/2010 12:26 AM, Erich Hoover wrote: When submitting multiple patches that apply to the same component but each patch is unrelated (ie. each one fixes a different issue), is it still appropriate to label the patches with the [PATCH X/Y] notation? In the case I have at hand the patches are

Re: Quick multiple-patch submission question

2010-01-28 Thread Juan Lang
> When submitting multiple patches that apply to the same component but > each patch is unrelated (ie. each one fixes a different issue), is it > still appropriate to label the patches with the [PATCH X/Y] notation? > In the case I have at hand the patches are even for different files of > the same

Quick multiple-patch submission question

2010-01-28 Thread Erich Hoover
When submitting multiple patches that apply to the same component but each patch is unrelated (ie. each one fixes a different issue), is it still appropriate to label the patches with the [PATCH X/Y] notation? In the case I have at hand the patches are even for different files of the same component

Re: WineD3D patch submission

2007-09-22 Thread Mitchell Wheeler
Stefan Dösinger wrote: > Hello Mitchell, > > First of all, thank you for your effort in improving Wine. People who pick > their favorite game(s) and fix bugs is exactly what we need these days :-) > > You should really get used to git for submitting patches. It requires a tiny > bit of learning e

Re: WineD3D patch submission

2007-09-22 Thread Stefan Dösinger
Hello Mitchell, First of all, thank you for your effort in improving Wine. People who pick their favorite game(s) and fix bugs is exactly what we need these days :-) You should really get used to git for submitting patches. It requires a tiny bit of learning effort in the beginning, but it pays

Re: WineD3D patch submission

2007-09-22 Thread Mirek Slugeň
Stefan Dösinger napsal(a): Am Samstag, 22. September 2007 13:45:11 schrieb Roderick Colenbrander: I tried this patch, everything works like before, can't find any regression in apps like ET: QW, Oblivion, all nvidia D3D SDK tests, 3DMarks and others. Titan Quest looks beter,

Re: WineD3D patch submission

2007-09-22 Thread Stefan Dösinger
Am Samstag, 22. September 2007 13:45:11 schrieb Roderick Colenbrander: > > I tried this patch, everything works like before, can't find any > > regression in apps like ET: QW, Oblivion, all nvidia D3D SDK tests, > > 3DMarks and others. Titan Quest looks beter, but there are still some > > issues in

Re: WineD3D patch submission

2007-09-22 Thread Roderick Colenbrander
> I tried this patch, everything works like before, can't find any > regression in apps like ET: QW, Oblivion, all nvidia D3D SDK tests, > 3DMarks and others. Titan Quest looks beter, but there are still some > issues in menu, game is not working because of gdi32.dll functionality. > I create

Re: WineD3D patch submission

2007-09-22 Thread <[EMAIL PROTECTED]>
I tried this patch, everything works like before, can't find any regression in apps like ET: QW, Oblivion, all nvidia D3D SDK tests, 3DMarks and others. Titan Quest looks beter, but there are still some issues in menu, game is not working because of gdi32.dll functionality. I create patch for a

Re: WineD3D patch submission

2007-09-22 Thread Roderick Colenbrander
> Hi all, > > A week or so ago I tried to get a game working in WINE (Titan Quest), > however it seems it really needs a proper DIB engine before it'll be > playable. > > Anyways, in my attempt to get it working I fixed up some issues w/ > "IWineD3DDeviceImpl_UpdateSurface.c" in dlls/wined3d

WineD3D patch submission

2007-09-21 Thread Mitchell Wheeler
Hi all, A week or so ago I tried to get a game working in WINE (Titan Quest), however it seems it really needs a proper DIB engine before it'll be playable. Anyways, in my attempt to get it working I fixed up some issues w/ "IWineD3DDeviceImpl_UpdateSurface.c" in dlls/wined3d, not entirely sur

Re: please help with patch submission

2006-07-31 Thread Neil Skrypuch
Clearly it was too early for me when I wrote that. I had counted the GUID length wrong (as 39 instead of 38), so the - 3 didn't make sense either. - Neil

Re: please help with patch submission

2006-07-31 Thread Damjan Jovanovic
--- Neil Skrypuch <[EMAIL PROTECTED]> wrote: > On Monday, July 31, 2006 06:37, Damjan Jovanovic > wrote: > > +WCHAR > guidStringWithBraces[MAX_GUID_STRING_LEN]; > > You need MAX_GUID_STRING_LEN + 1 to store the null > too, if I'm not mistaken. 0 1 2 3 01234567890123

Re: please help with patch submission

2006-07-31 Thread Neil Skrypuch
On Monday, July 31, 2006 06:37, Damjan Jovanovic wrote: > +    WCHAR guidStringWithBraces[MAX_GUID_STRING_LEN]; You need MAX_GUID_STRING_LEN + 1 to store the null too, if I'm not mistaken. > +CopyMemory(&guidStringWithBraces[1], lpGuidString, > +(MAX_GUID_STRING_LEN - 3) * sizeof(WCHA

please help with patch submission

2006-07-31 Thread Damjan Jovanovic
Hi I have a short patch that fixes serious bugs I've encountered in setupapi's SetupDiOpenClassRegKeyExW(). It's been mailed twice to wine-patches and is attached for reference. Is there anything wrong with it? Please comment. Thank you Damjan __

[Fwd: Re: msi patch submission - cond.y]

2006-06-05 Thread Dominic Wise
rror, even if it doesn't pertain > to SQL. > > Do these not mean IS Greater than or equal to, or Is Less than or Equal to ? > > > > >From: Mike McCormack <[EMAIL PROTECTED]> > >To: wine-devel@winehq.org > >CC: [EMAIL PROTECTED] > >Subject: Re:

Re: msi patch submission - cond.y

2006-06-05 Thread EA Durbin
looked up 'tilde' and MSI on Google, it looks as though COND_I* actually relates to strings, as it seems that the tilde means 'case insensitive', but I wonder if it has been inadvertently used on integer comparisons by some installers]. Coming from perl, I though the tilde was part of a regex a

Re: msi patch submission - cond.y

2006-06-05 Thread Dominic Wise
McCormack <[EMAIL PROTECTED]> > >To: wine-devel@winehq.org > >CC: [EMAIL PROTECTED] > >Subject: Re: msi patch submission - cond.y > >Date: Mon, 05 Jun 2006 22:43:09 +0900 > > > > > >EA Durbin wrote: > >>fixed various SQL errors in COND_GetOperator() and compare_int() > > > >Unfortunately cond.y has nothing to do with SQL. > > > >Mike > > > > >

Re: msi patch submission - cond.y

2006-06-05 Thread EA Durbin
or Is Less than or Equal to ? From: Mike McCormack <[EMAIL PROTECTED]> To: wine-devel@winehq.org CC: [EMAIL PROTECTED] Subject: Re: msi patch submission - cond.y Date: Mon, 05 Jun 2006 22:43:09 +0900 EA Durbin wrote: fixed various SQL errors in COND_GetOperator() and compare_int() Unfo

Re: msi patch submission - cond.y

2006-06-05 Thread Hans Leidekker
On Monday 05 June 2006 15:33, EA Durbin wrote: > Is IGE not is greater than or equal to, and shouldn't the sign for that be > >= rather than <=, or does IGE mean something else, perfect example of > were comments should be, after all the function should be written perfectly I don't think that's e

Re: msi patch submission - cond.y

2006-06-05 Thread Mike McCormack
EA Durbin wrote: fixed various SQL errors in COND_GetOperator() and compare_int() Unfortunately cond.y has nothing to do with SQL. Mike

Re: msi patch submission - cond.y

2006-06-05 Thread EA Durbin
trying to view it from an outside perspective to determine how it works. From: Mike McCormack <[EMAIL PROTECTED]> To: EA Durbin <[EMAIL PROTECTED]> CC: wine-devel@winehq.org Subject: Re: msi patch submission - cond.y Date: Mon, 05 Jun 2006 19:37:43 +0900 EA Durbin wrote: fixed

Re: msi patch submission - cond.y

2006-06-05 Thread Mike McCormack
EA Durbin wrote: fixed various SQL errors in COND_GetOperator() and compare_int() IMO, both of your patches are incorrect. I'm waiting for your test case. Mike

Re: patch submission

2006-05-26 Thread Chris Morgan
I just noticed that I had your patch applied locally but not committed. When I tried to commit there was an issue reaching winehq cvs. I was going to go back but forgot. Its all set now :-) Chris On Thursday 25 May 2006 2:09 pm, EA Durbin wrote: > Is there any way to expedite the pa

Re: patch submission

2006-05-25 Thread Chris Morgan
ECTED]> wrote: Is there any way to expedite the patch submission process. I submitted a patch to wine-patches quite a while ago for the AppDB TestResulsts.php page as outlined in bug 5155. How long does this take to implement?

patch submission

2006-05-25 Thread EA Durbin
Is there any way to expedite the patch submission process. I submitted a patch to wine-patches quite a while ago for the AppDB TestResulsts.php page as outlined in bug 5155. How long does this take to implement?

Re: Easy patch submission with GIT + imap folders

2006-04-19 Thread Alexandre Julliard
Mike McCormack <[EMAIL PROTECTED]> writes: > Using Mozilla, you can just click on the "Edit Draft:" in the message, > check/edit the message and then click send. > > Alexandre has said that he doesn't mind if the subject line contains > the ChangeLog entry. Not only I don't mind, but I'd strongly

Re: Easy patch submission with GIT + imap folders

2006-04-19 Thread Mike McCormack
Michael Stefaniuc wrote: Tunnel = "ssh -q [EMAIL PROTECTED] /usr/bin/imapd ./Maildir 2> /dev/null" What to put in here if one uses imaps? That should be the "normal" way of using imap this days. Unfortunately it doesn't support imaps as yet. There was code to support imaps in th

Re: Easy patch submission with GIT + imap folders

2006-04-19 Thread Michael Stefaniuc
Mike McCormack wrote: As of the recently released GIT 1.3.0, sending patches via an IMAP folder with GIT just got easier. If everything is set up right, you should be able to run the following command: git-format-patch --attach --stdout --keep origin | git-imap-send This requires some confi

Easy patch submission with GIT + imap folders

2006-04-18 Thread Mike McCormack
Hi, As of the recently released GIT 1.3.0, sending patches via an IMAP folder with GIT just got easier. If everything is set up right, you should be able to run the following command: git-format-patch --attach --stdout --keep origin | git-imap-send This requires some configuration in ~/.gi

Re: Patch submission

2006-04-10 Thread Robert Shearman
Andreas Mohr wrote: Hi, On Sun, Apr 09, 2006 at 01:19:45PM -0400, n1iic Jason Greene wrote: Greetings. I am a new Linux user, and I would like to request a patch addition to add functionality for a game. Oh, not so scared, please ;) The information can be found at http://wiki.m

Re: Patch submission

2006-04-10 Thread Andreas Mohr
Hi, On Sun, Apr 09, 2006 at 01:19:45PM -0400, n1iic Jason Greene wrote: > Greetings. I am a new Linux user, and I would like to request a patch > addition to add functionality for a game. Oh, not so scared, please ;) > The information can be found at > http://wiki.minegoboom.com/index.php/Run

Patch submission

2006-04-09 Thread n1iic Jason Greene
Greetings. I am a new Linux user, and I would like to request a patch addition to add functionality for a game. The information can be found at http://wiki.minegoboom.com/index.php/Running_Continuum_under_Wine I think for the people that want to learn Linux, applying the patch is a great ex