Huw Davies <[EMAIL PROTECTED]> writes:
> Ok, I'll send in a patch with todo_wine and let you decide.
>
> My feeling was that without opengl support we should skip the opengl32
> tests, hence the skip in the original patch. The todo_wine was to
> flag Wine's ChoosePixelFormat bug.
My concern is t
On Mon, Dec 08, 2008 at 01:44:41PM +0100, Alexandre Julliard wrote:
> Huw Davies <[EMAIL PROTECTED]> writes:
>
> > Hi Alexandre,
> >
> > This wasn't what I intended my patch to do. The problem is that
> > Wine's ChoosePixelFormat() rets 0 on XServers without glX. The
> > win_skip results in a te
Huw Davies <[EMAIL PROTECTED]> writes:
> Hi Alexandre,
>
> This wasn't what I intended my patch to do. The problem is that
> Wine's ChoosePixelFormat() rets 0 on XServers without glX. The
> win_skip results in a test failure. My patch was intended to mark
> this as a todo_wine.
We could have a
ies <[EMAIL PROTECTED]>
> Date: Fri Dec 5 14:19:25 2008 +
>
> opengl/tests: Skip tests if we can't find a pixel format.
>
> ---
>
> dlls/opengl32/tests/opengl.c |9 -
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git
On Fri, Dec 05, 2008 at 03:25:56PM +0100, Paul Vriens wrote:
> This looks a bit strange:
>
> +if(iPixelFormat == 0)
> +{
> +todo_wine ok(iPixelFormat > 0,
>
>
> Is it your intention to just throw up a failed message in all cases?
Hi Paul,
It was my intention to thro
Huw Davies wrote:
> ---
> dlls/opengl32/tests/opengl.c |8
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
>
>
>
>
Hi Huw,
This looks a bit strange:
+if(iPixelFormat == 0)
+{
+
