Re: oledb32: Implement CanConvert.

2009-09-21 Thread Paul Chitescu
On Monday 21 September 2009 16:46:25 Huw Davies wrote: > On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > > S_FALSE; > > > > I think this ne

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Marcus Meissner
On Mon, Sep 21, 2009 at 02:46:25PM +0100, Huw Davies wrote: > On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > > S_FALSE; > > > > I think

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Huw Davies
On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > S_FALSE; > > I think this needs brackets... Why? It's equivalent to: if((src_type & DBTYP

Re: oledb32: Implement CanConvert.

2009-09-21 Thread Marcus Meissner
On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > --- > dlls/oledb32/convert.c | 231 > +- > dlls/oledb32/tests/convert.c | 10 -- > 2 files changed, 228 insertions(+), 13 deletions(-) > diff --git a/dlls/oledb32/convert.c b/dlls/oledb3