On Fri, Aug 21, 2009 at 1:42 PM, Juan Lang wrote:
> Ah, fair enough, and clearly oleaut32 belongs in that category. Thanks.
I should have said Windows as technically mingw is still __GNUC__ but
you got the idea.
--
Steven Edwards
"There is one thing stronger than all the armies in the world, a
> There are a few instances of it, at least in code we care about
> sharing with a mingw build
Ah, fair enough, and clearly oleaut32 belongs in that category. Thanks.
--Juan
On Fri, Aug 21, 2009 at 12:31 PM, Juan Lang wrote:
> We don't protect by __GNUC__ for any of our other assembly either,
> even though it all uses GNU assembly syntax. So personally I think
> that part's okay.
There are a few instances of it, at least in code we care about
sharing with a mingw bui
Thanks for the review, Henri.
> I don't know if there's a reason the general approach couldn't work,
> but the code in the patch is gcc specific, so I think it should at
> least be protected by __GNUC__ in addition to __i386__.
We don't protect by __GNUC__ for any of our other assembly either,
ev
2009/8/21 Juan Lang :
> Personally, I don't think the cut-and-paste approach we've been taking
> to fix this works all that well for a 126-argument function, so it
> seems like an assembly approach is the only tenable method. I'm not
> certain whether Jon's approach is the correct one, but since i
