Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2330
Your paranoid andr
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://newtestbot.winehq.org/JobDetails.pl?Key=2280
Your paranoid andr
On Tue, Sep 17, 2013 at 3:01 PM, Andrew Eikum wrote:
> This fixes a crash in PowerPoint when a shape is made
> semi-transparent.
May also fix bug http://bugs.winehq.org/show_bug.cgi?id=34463 and
http://bugs.winehq.org/show_bug.cgi?id=30485
On 8/30/2013 16:28, Piotr Caban wrote:
---
dlls/oleaut32/tests/typelib.c | 13 +++--
dlls/oleaut32/typelib.c | 13 +++--
2 files changed, 22 insertions(+), 4 deletions(-)
ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface);
-FIXME("%p %u %s - s
LoadRegTypeLib() with activated context
It doesn't work here:
../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so
tmarshal.c&& touch tmarshal.ok
tmarshal.c:999: Test failed: LoadRegTypeLib failed with error 0x8002801d
tmarshal.c:1232
activated context
It doesn't work here:
../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p
oleaut32_test.exe.so tmarshal.c && touch tmarshal.ok
tmarshal.c:999: Test failed: LoadRegTypeLib failed with error 0x8002801d
tmarshal.c:1232: Test failed: IKindaEnumWidget_Next fa
On 08/20/13 16:57, Andrew Eikum wrote:
@@ -10530,8 +10541,28 @@ static HRESULT WINAPI
ICreateTypeInfo2_fnSetTypeDescAlias(ICreateTypeInfo2 *ifac
+This->cbSizeInstance = VARIANT_DataSize(This->tdescAlias->vt,
This->pTypeLib->ptr_size);
+if(!This->cbSizeInstance){
+FIXME("Wrong si
On 08/16/13 21:40, Andrew Eikum wrote:
@@ -8502,7 +8502,7 @@ static HRESULT WINAPI
ICreateTypeLib2_fnCreateTypeInfo(ICreateTypeLib2 *iface,
info->cbSizeInstance = 2;
break;
case TKIND_ALIAS:
-info->cbSizeInstance = -0x75;
+info->cbSizeInstance = 4;
On Fri, Aug 02, 2013 at 04:29:07PM +0200, Alexandre Julliard wrote:
> Marcus Meissner writes:
>
> > Triggered by the Novell Groupwise installer currently,
> > from the ISBE64W.exe Installshield Helper program.
> >
> > The typelib is contained directly in ISBE64W.exe itself :/
> >
> > Basically if
Marcus Meissner writes:
> Triggered by the Novell Groupwise installer currently,
> from the ISBE64W.exe Installshield Helper program.
>
> The typelib is contained directly in ISBE64W.exe itself :/
>
> Basically if we encounter this case the program will crash
> anyway (but with random backtrace),
On 06/30/13 23:29, Thomas Faber wrote:
> I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it
> complained:
> tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [
> Interface 'ITestSecondDisp' ]
>
> This doesn't seem like
I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it
complained:
tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [
Interface 'ITestSecondDisp' ]
This doesn't seem like it's intentional. But just giving
ITestSecondDisp a new uuid cause
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26136
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26136
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=25960
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=25961
Your paranoid android
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=25849
Your paranoid android
, too.
Whichever.
Andrew
On Wed, May 08, 2013 at 03:12:45PM -0500, Andrew Eikum wrote:
> ---
> dlls/oleaut32/typelib.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
> inde
Sorry, I should have labelled this patch as "Try 2".
--
Andy.
On 12/20/2012 14:50, Tatyana Fokina wrote:
Hi, Tatyana.
Main problem is that your test will crash if run without patch 2/2,
that's not how it should be done.
You need to merge these patches together to keep tests working or send
implementation fix first,
so next test patch will work.
+h
Andrew Talbot writes:
> Changelog:
> oleaut32: Indentation Fix.
Please avoid reformatting hundreds of lines for no reason. Only fix the
parts where the indentation is actually incorrect.
--
Alexandre Julliard
julli...@winehq.org
Alistair Leslie-Hughes writes:
> diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c
> index fa9b050..04914e0 100644
> --- a/dlls/oleaut32/typelib.c
> +++ b/dlls/oleaut32/typelib.c
> @@ -2544,9 +2544,11 @@ static HRESULT TLB_PEFile_Open(LPCWSTR path, INT
> ind
Heh, sure I can do that. I did that initially with test_tlb.idl but after
that I got a bunch of failures cause of existing tests. I will update
existing tests then.
On Fri, Dec 14, 2012 at 7:09 PM, Alexandre Julliard wrote:
> Nikolay Sivov writes:
>
> > Don't know what it wants here. Probably i
Nikolay Sivov writes:
> Don't know what it wants here. Probably it doesn't like new idl file?
I don't like it either ;-) Any chance you could put that in one of the
existing files?
--
Alexandre Julliard
julli...@winehq.org
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=23397
Your paranoid android
Don't know what it wants here. Probably it doesn't like new idl file?
On Fri, Dec 14, 2012 at 3:15 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but co
Nikolay Sivov wrote 07.11.2012 13:45:
On 11/7/2012 11:36, Tatyana Fokina wrote:
Hi, Tatyana.
Some comments:
dlls/oleaut32/tests/Makefile.in | 1 +
dlls/oleaut32/tests/typelib2.c | 69
+
2 files changed, 70 insertions(+)
create mode 100644
On Thu, Nov 08, 2012 at 06:13:33PM +0400, Tatyana Fokina wrote:
> +if(ppTLib)
> +{
> *ppTLib = (ITypeLib *)&This->typelib->ITypeLib2_iface;
> ICreateTypeLib_AddRef((ICreateTypeLib*)This->typelib);
> +}
> +
> +if(pIndex)
> *pIndex = This->typeinfo->typekind >> 16;
Ple
On Thu, Nov 08, 2012 at 06:13:28PM +0400, Tatyana Fokina wrote:
> +hr = CreateTypeLib2(SYS_WIN32, jsdeb, (ICreateTypeLib2 **)&ctl2);
> +ok_ole_success(hr, CreateTypeLib2);
> +
> +hr = ICreateTypeLib2_CreateTypeInfo(ctl2, jsname, TKIND_DISPATCH, &cti);
> +ok_ole_success(hr, ICreateTy
From c4bc53b10a531e389dc36fb29d1f308051f10b49 Mon Sep 17 00:00:00 2001
From: tatyana
Date: Wed, 7 Nov 2012 12:24:50 +0400
Subject: [PATCH 5/5] oleaut32: If pointers (ppTLib or pIndex) are null, we
simply ignore it (eterbug #8365)
---
dlls/oleaut32/typelib2.c | 5 +
1 file changed, 5
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22807
Your paranoid android
On 11/7/2012 11:36, Tatyana Fokina wrote:
Hi, Tatyana.
Some comments:
dlls/oleaut32/tests/Makefile.in | 1 +
dlls/oleaut32/tests/typelib2.c | 69 +
2 files changed, 70 insertions(+)
create mode 100644 dlls/oleaut32/tests/typelib2.c
You don&#
, just use the number 8 in
> the for loop instead.
> ---
> dlls/oleaut32/tests/tmarshal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c
> index be8ef94..ad56123 100644
> ---
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=21195
Your paranoid android
Alistair Leslie-Hughes wrote:
> Changelog:
> oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
Please resend the test separately, your fix conflicts with the patch
sent by Roman Dadkov.
--
Dmitry.
Jacek Caban writes:
> @@ -6509,6 +6510,38 @@ static HRESULT WINAPI ITypeInfo_fnInvoke(
> {
> prgpvarg[i] = src_arg;
> }
> +
> +if((tdesc->vt == VT_USERDEFINED || (tdesc->vt == VT_PTR
> && tdesc->u.lptdesc->vt
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://winetestbot.dolphin/JobDetails.pl?Key=87
Your paranoid android.
oleaut32_instance)
>> +FreeLibrary(oleaut32_instance);
> Since oleaut32 imports ole32 you'll never get here.
Oh, right, that was stupid.
> Using a delayed import would probably be easier.
That was my first idea, but I realized that in this case we may easily
end up usin
Jacek Caban writes:
> @@ -1244,6 +1244,9 @@ static void COMPOBJ_InitProcess( void )
> static void COMPOBJ_UninitProcess( void )
> {
> UnregisterClassW(wszAptWinClass, hProxyDll);
> +
> +if(oleaut32_instance)
> +FreeLibrary(oleaut32_instance);
Since o
;ll rephrase it: yes, I tested
the affected application under Windows, and setting OANOCACHE breaks it.
With native oleaut32.dll the app works perfectly under Wine, setting
OANOCACHE breaks it same way as under Windows.
--
Dmitry.
On 06/05/12 13:31, Dmitry Timoshkov wrote:
> Jacek Caban wrote:
>
>> BTW, did you test the app on Windows with disabled BSTR cache? It's easy
>> to do by setting OANOCACHE environment variable before running the app.
>> If that breaks the app, then indeed the app is broken in a way that it
>> depe
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> That doesn't seem very useful. What use case would there be for an app
>> to rely on some random 75% of its strings to remain valid?
>
> Although the test is about statistics, my intention was to show that BSTR
> cache in Wine corrupts ca
Jacek Caban wrote:
> BTW, did you test the app on Windows with disabled BSTR cache? It's easy
> to do by setting OANOCACHE environment variable before running the app.
> If that breaks the app, then indeed the app is broken in a way that it
> depends on BSTR cache behaviour.
It's easy to test un
Hi Dmitry,
On 06/05/12 13:05, Dmitry Timoshkov wrote:
> Alexandre Julliard wrote:
>
>> That doesn't seem very useful. What use case would there be for an app
>> to rely on some random 75% of its strings to remain valid?
> Although the test is about statistics, my intention was to show that BSTR
>
Alexandre Julliard wrote:
> That doesn't seem very useful. What use case would there be for an app
> to rely on some random 75% of its strings to remain valid?
Although the test is about statistics, my intention was to show that BSTR
cache in Wine corrupts cached strings. I could try to figure o
Dmitry Timoshkov writes:
> +for (i = 0; i < sizeof(bstr)/sizeof(bstr[0]); i++)
> +{
> +INTERNAL_BSTR *data = Get(bstr[i]);
> +
> +for (j = 0; j < i; j++) str[j] = '0' + i % 10;
> +
> +if (data->dwLen == i * sizeof(WCHAR))
> +good_length_entries++;
> +
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=18731
Your paranoid android
On Thu, Sep 15, 2011 at 08:28:53AM, Marcus Meissner wrote:
> On Thu, Sep 15, 2011 at 02:09:56PM +0200, Bernhard Loos wrote:
> > ---
> > dlls/oleaut32/olepicture.c | 148
> > +-----
> > dlls/oleaut32/tests/olepicture.c | 16 ++-
On Thu, Sep 15, 2011 at 02:09:56PM +0200, Bernhard Loos wrote:
> ---
> dlls/oleaut32/olepicture.c | 148
> +-
> dlls/oleaut32/tests/olepicture.c | 16 ++---
> 2 files changed, 54 insertions(+), 110 deletions(-)
Did make check wo
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=14259
Your paranoid android
Am 03.08.2011 22:14, schrieb Octavian Voicu:
> 2011/8/3 André Hentschel mailto:n...@dawncrow.de>>
>
> a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6
>
>
> Doesn't look like a valid commit... which one is that?
>
> Octavian
sry, i mean 862cc73fb4cd8e6c8d454ab822a70a5072cb5dda
--
Best Regards,
2011/8/3 André Hentschel
> a80a90fcb7f917ef4ec999007f5a49eb63d1b0a6
>
Doesn't look like a valid commit... which one is that?
Octavian
André Hentschel writes:
> The hole test_ function depends on succeeding here (more than i thought first)
Actually you'd want to skip even more than that, the real failure is
earlier.
--
Alexandre Julliard
julli...@winehq.org
On Tue, Jul 12, 2011 at 1:19 PM, Alistair Leslie-Hughes
wrote:
> Hi,
>
>
> Changelog:
> oleaut32: Add DISPID_PICT_RENDER support to OLEPictureImpl_Invoke
>
+ case DISPID_PICT_RENDER:
+if (wFlags & DISPATCH_METHOD)
+{
+ TRACE("DISPID_PICT_RENDER %d %
Hi,
isn't there a white space issue? (trailing)
Regards,
W.
On Thu, Jul 7, 2011 at 2:09 PM, Alistair Leslie-Hughes
wrote:
> Hi,
>
>
> Changelog:
> oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
>
+ICreateTypeInfo2Impl *This = impl_from_ICreateTypeInfo2(iface);
+
+TRACE("(%p,%d), stub!\n", iface, dwHelpStr
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=12210
Your paranoid android
Hello Alistair,
sorry that I missed the first time. And Alexandre should have marked it
as PENDING (good idea but current implementation is rejected).
Alistair Leslie-Hughes wrote:
> Changelog:
> oleaut32: COM Cleanup ICreateTypeLib2Imp
>
>
> Best Regards
> Alis
Hello Alistair,
Alistair Leslie-Hughes wrote:
> Changelog:
> oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext
>
> dlls/oleaut32/typelib2.c |9 +++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/oleaut32/typelib2.c b/dll
On Thu, May 19, 2011 at 11:30 AM, Austin English
wrote:
> --
> -Austin
>
>
>
>
This test should use a table+loop I think.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=9472
Your paranoid android.
; To: wine-patches
>
> ---
> dlls/oleaut32/usrmarshal.c | 10 ++
> 1 files changed, 6 insertions(+), 4 deletions(-)
This looks good to me. I'm not sure why this function is marked as
[call_as], I expect they originally had planned to allow for a NULL
pcNames if cMax
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8987
Your paranoid android.
On 1/24/2011 12:38, Michael Stefaniuc wrote:
Hello Nikolay,
On 01/24/2011 01:01 AM, Nikolay Sivov wrote:
Use implementation pointer to trace ICreateTypeInfo2
diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c
index 8260ef2..5c843a1 100644
--- a/dlls/oleaut32/typelib2.c
+++ b
Hello Nikolay,
On 01/24/2011 01:01 AM, Nikolay Sivov wrote:
Use implementation pointer to trace ICreateTypeInfo2
diff --git a/dlls/oleaut32/typelib2.c b/dlls/oleaut32/typelib2.c
index 8260ef2..5c843a1 100644
--- a/dlls/oleaut32/typelib2.c
+++ b/dlls/oleaut32/typelib2.c
@@ -2322,6 +2321,7
Nikolay Sivov writes:
> Remove S_OK value assumptions, fix potential stream leak
Returning an error value and 0 on success is a common pattern, using a
magic constant for 0 is not an improvement.
--
Alexandre Julliard
julli...@winehq.org
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=7587
Your paranoid android.
Andrew Eikum writes:
> Typelib objects on Windows support both the reading and the creation
> interfaces. I find it unlikely that they maintain two different
> structures depending on which interface is being used, as Wine
> currently (sort of) does. I think the question is whether the
> struct
On 12/13/2010 10:03 AM, Alexandre Julliard wrote:
Andrew Eikum writes:
An array would work, especially for the static structures that are
used now, but these cleanup patches were made with the goal of merging
the typelib-reading and typelib-creation interfaces in mind.
Specifically, impleme
Andrew Eikum writes:
> An array would work, especially for the static structures that are
> used now, but these cleanup patches were made with the goal of merging
> the typelib-reading and typelib-creation interfaces in mind.
> Specifically, implementing the typelib-creation interfaces using the
On 12/13/2010 05:34 AM, Alexandre Julliard wrote:
Andrew Eikum writes:
-/* search element n in list */
-for(i=0; i< index; i++)
+i = 0;
+LIST_FOR_EACH_ENTRY (pTypeInfo,&This->typeinfo_list, ITypeInfoImpl, entry)
+{
+if(i>= index)
+break;
+
Andrew Eikum writes:
> -/* search element n in list */
> -for(i=0; i < index; i++)
> +i = 0;
> +LIST_FOR_EACH_ENTRY (pTypeInfo, &This->typeinfo_list, ITypeInfoImpl,
> entry)
> +{
> +if(i >= index)
> +break;
> +++i;
> +}
It looks like an array
On 11/17/2010 02:00, Adam Martinson wrote:
---
dlls/msxml3/tests/domdoc.c |4 ++--
dlls/oleaut32/variant.c| 17 +
2 files changed, 11 insertions(+), 10 deletions(-)
If oleaut32 needs a fix like this, please add a test for it in
oleaut32/tests, fixed msxml tests will
André Hentschel writes:
> @@ -10,7 +10,7 @@ C_SRCS = \
> typelib.c \
> usrmarshal.c \
> varformat.c \
> - vartest.c \
> + variant.c \
> vartype.c
Renaming tests should be avoided, it makes it hard to follow the history
on test.winehq.org.
--
Alexandre Julliard
j
Fredag 15 oktober 2010 07:48:17 skrev Trygve Vea :
>
What is being changed here?
Alexander N. Sørnes
On 10/2/10 7:00 PM, Jeremy Drake wrote:
On Sat, 2 Oct 2010, James McKenzie wrote:
Looks like you got 'bit' by the way that a finite storage method mangles
floating information. There was a lengthy discussion on how to 'overcome'
this on the Wine-Development list a short while ago.
No, those
On Sat, 2 Oct 2010, James McKenzie wrote:
> Looks like you got 'bit' by the way that a finite storage method mangles
> floating information. There was a lengthy discussion on how to 'overcome'
> this on the Wine-Development list a short while ago.
No, those tests aleady account for that.
/* Whe
On 10/2/10 10:13 AM, (Marvin) wrote:
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDe
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=5729
Your paranoid android.
ne had no test coverage for these cases. Until now.
>
>
>
> ---
> dlls/oleaut32/tests/vartest.c | 32 +++-
> 1 files changed, 23 insertions(+), 9 deletions(-)
--
Egotist, n.:
A person of low taste, more interested in himself than me.
Jan Ohlsen wrote:
> + case TKIND_COCLASS: {
> + ITypeInfo *pSubTypeInfo = NULL;
> + TYPEATTR*tattr2 = NULL;
> + GUID*iid = &(tattr->guid);
Once you set tab size to 8 in your editor, or better will not use tabs
at all, you will notice that
On Mon, Sep 6, 2010 at 6:18 PM, Vincent Povirk wrote:
> + // Use IID of the coclass' default
> interface
>
> Don't use C++ comments.
>
> On Mon, Sep 6, 2010 at 10:31 AM, Jan Ohlsen
> wrote:
> >
> &g
+ // Use IID of the coclass' default interface
Don't use C++ comments.
On Mon, Sep 6, 2010 at 10:31 AM, Jan Ohlsen wrote:
>
> ---
> dlls/oleaut32/tmarshal.c | 69
> ++
> 1 files changed, 69 insertions(+), 0 deletions(-)
>
>
>
>
>
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4737
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4738
Your paranoid android.
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=3687
Your paranoid android.
Hi Thomas,
On 5/17/10 3:05 AM, Thomas Mullaly wrote:
Added tests to make sure IUri_GetPropertyBSTR / IUri_GetPropertyDWORD
/ IUri_GetPropertyLength handle invalid arguments correctly. Fixed
up/added some comments.
Had to add a dependency to urlmon for oleaut32. This is because the
Uri
On 4/14/2010 23:56, André Hentschel wrote:
Nikolay Sivov schrieb:
On 4/14/2010 22:51, André Hentschel wrote:
case 0x3: /* TTT TTTDD TTTDDD */
- if (iDate&& dp.dwCount == 3)
+ if (dp.dwCount == 3&& !strncmp(ShortDate,"dd.MM.yy",8))
case 0x1B
Nikolay Sivov schrieb:
> On 4/14/2010 22:51, André Hentschel wrote:
>> case 0x3: /* TTT TTTDD TTTDDD */
>> - if (iDate&& dp.dwCount == 3)
>> + if (dp.dwCount == 3&& !strncmp(ShortDate,"dd.MM.yy",8))
>>
>>
>
>> case 0x1B: /* localized DDDTTT */
>> - if (!iDate)
>> +
On 4/14/2010 22:51, André Hentschel wrote:
case 0x3: /* TTT TTTDD TTTDDD */
- if (iDate&& dp.dwCount == 3)
+ if (dp.dwCount == 3&& !strncmp(ShortDate,"dd.MM.yy",8))
case 0x1B: /* localized DDDTTT */
- if (!iDate)
+ if (strncmp(ShortDate,"dd.MM.yy",8))
André Hentschel writes:
> @@ -7708,7 +7708,7 @@ HRESULT WINAPI VarDateFromStr(OLECHAR* strIn, LCID
> lcid, ULONG dwFlags, DATE* pd
>break;
>
> case 0x1B: /* localized DDDTTT */
> - if (!iDate)
> + if (PRIMARYLANGID(lcid) != LANG_GERMAN)
Obviously you cannot hardcode spe
A test case would be a good idea.
After spending a consider amount of time trying to writing a test case, It
always failed on an XP box.
This patch would just hide the issue instead of truly fixing it.
Best Regards
Alistair Leslie-Hughes
Piotr Caban writes:
> On 03/18/10 17:42, Paul Vriens wrote:
>> Patch is committed. So all you need to do now if fix the 64bit
>> implementation (if that's indeed the case) ;)
>
> As far as I know both oleaut typelib creation and widl are not working
> well on 64bit systems (is widl ever compiled
On 03/18/10 17:42, Paul Vriens wrote:
Patch is committed. So all you need to do now if fix the 64bit
implementation (if that's indeed the case) ;)
As far as I know both oleaut typelib creation and widl are not working
well on 64bit systems (is widl ever compiled as 64bit application?). It
wil
On 03/18/2010 05:26 PM, Paul Vriens wrote:
On 03/18/2010 05:23 PM, Piotr Caban wrote:
This test is only failing on some wine boxes, that doesn't have
oleaut2.tlb registered (or QueryPathOfRegTypeLib is broken). It probably
happens only when 64bit tests are being run.
Ok, that makes the approac
On 03/18/2010 05:23 PM, Piotr Caban wrote:
This test is only failing on some wine boxes, that doesn't have
oleaut2.tlb registered (or QueryPathOfRegTypeLib is broken). It probably
happens only when 64bit tests are being run.
Ok, that makes the approach a bit different.
Should I check if we'r
This test is only failing on some wine boxes, that doesn't have
oleaut2.tlb registered (or QueryPathOfRegTypeLib is broken). It probably
happens only when 64bit tests are being run.
Should I check if we're running in 64bit tests and add todo_wine in this
case?
On 03/18/2010 05:03 PM, Piotr Caban wrote:
Hi,
If it's acceptable to get something else besides S_OK you should change
the ok() and add a broken() (still bail out of course).
It's not acceptable to get anything else than S_OK here. I thought skip
should be used to inform that not all tests are
Hi,
If it's acceptable to get something else besides S_OK you should change
the ok() and add a broken() (still bail out of course).
It's not acceptable to get anything else than S_OK here. I thought skip
should be used to inform that not all tests are being executed.
A skip() usually means t
On 03/17/2010 10:05 PM, Piotr Caban wrote:
hres = ICreateTypeInfo_AddRefTypeInfo(createti, unknown,&hreftype);
ok(hres == S_OK, "got %08x\n", hres);
+if(hres != S_OK) {
+skip("Skipping some tests\n");
+return;
+}
Hi Piotr,
If it's acceptable to get something
1 - 100 of 426 matches
Mail list logo
