Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Bill Medland
On January 10, 2005 11:40 am, Robert Shearman wrote: > Paul Vriens wrote: > >On Mon, 2005-01-10 at 18:02, Robert Shearman wrote: > >>The parameter to CoInitializeEx is of type COINIT and so the caller can > >> also specify another flag like COINIT_DISABLE_OLE1DDE along with the > >> apartment flag.

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Robert Shearman
Paul Vriens wrote: On Mon, 2005-01-10 at 18:02, Robert Shearman wrote: The parameter to CoInitializeEx is of type COINIT and so the caller can also specify another flag like COINIT_DISABLE_OLE1DDE along with the apartment flag. So we either need to convert the values to booleans before we call t

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Paul Vriens
On Mon, 2005-01-10 at 18:02, Robert Shearman wrote: > Paul Vriens wrote: > > >Hi, > > > >while looking through the code I saw: > > > >if (model & COINIT_MULTITHREADED) > > > >this will never work as COINIT_MULTITHREADED = 0. > > > > > > Good catch. > > >The attached patch fixes the 3 occurrenc

Re: ole32 : wrong check in compobj.c

2005-01-10 Thread Robert Shearman
Paul Vriens wrote: Hi, while looking through the code I saw: if (model & COINIT_MULTITHREADED) this will never work as COINIT_MULTITHREADED = 0. Good catch. The attached patch fixes the 3 occurrences of a check against COINIT_*. This patch however makes the COM_CreateApartment in compobj.c: 5

ole32 : wrong check in compobj.c

2005-01-10 Thread Paul Vriens
Hi, while looking through the code I saw: if (model & COINIT_MULTITHREADED) this will never work as COINIT_MULTITHREADED = 0. The attached patch fixes the 3 occurrences of a check against COINIT_*. This patch however makes the COM_CreateApartment in compobj.c: 545 if (!(apt = COM_Curren