Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > The patch actually removes the casts, the only cast that remains is the >> > cast >> > on the caller's side for the vtable pointer (which is much cleaner IMO >> > since >> > every COM object implements IUnknown), but the implementatio

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > The patch actually removes the casts, the only cast that remains is the cast > > on the caller's side for the vtable pointer (which is much cleaner IMO since > > every COM object implements IUnknown), but the implementation itself is cast > > free, and looks now as a

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > The patch actually removes the casts, the only cast that remains is the cast > on the caller's side for the vtable pointer (which is much cleaner IMO since > every COM object implements IUnknown), but the implementation itself is cast > free, and looks now as an actual

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This patch should be quite obvious in its intent: it changes vtable type > > to IUnknown which helps to remove This* to IUnknown* casts in order to > > avoid obvious problems with vtable pointer placement inside of object > > implementation. Basically this is just a

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch should be quite obvious in its intent: it changes vtable type > to IUnknown which helps to remove This* to IUnknown* casts in order to > avoid obvious problems with vtable pointer placement inside of object > implementation. Basically this is just a clean up

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-23 Thread Dmitry Timoshkov
This patch should be quite obvious in its intent: it changes vtable type to IUnknown which helps to remove This* to IUnknown* casts in order to avoid obvious problems with vtable pointer placement inside of object implementation. Basically this is just a clean up patch. Is there anything else to c