Re: ntdll: Remove more path trailing chars. (try 2)

2011-04-18 Thread Alexandre Julliard
Vincent Pelletier writes: > Add tests via FindFirstFileA. You need tests for the low-level ntdll functions. -- Alexandre Julliard julli...@winehq.org

Re: ntdll: Remove more path trailing chars.

2011-04-08 Thread Vincent Pelletier
Le vendredi 08 avril 2011 13:05:18, joerg-cyril.hoe...@t-systems.com a écrit : > It means tests never fail on native, which renders the test useless. That's exactly my point. I started writing a mail to describe just what you said, with the extra data that on wine, test will verify something deci

ntdll: Remove more path trailing chars.

2011-04-08 Thread Joerg-Cyril.Hoehle
Hi, Juan Lang wrote: >Vincent Pelletier wrote: >> Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any >> sense. >> I saw that it is discouraged (forbidden ?) to depend on OS version in tests, >> so I will avoid that path unless asked to follow it. >You'd want to use "ok(p

Re: ntdll: Remove more path trailing chars.

2011-04-05 Thread Nikolay Sivov
On 4/5/2011 23:36, Vincent Pelletier wrote: Hi. Le samedi 02 avril 2011 09:16:53, Nikolay Sivov a écrit : Please use table for test data and put your macro body in a loop. Done locally (indeed nicer). I have one more thing to figure out before posting again: how to deal with the NT4 failures t

Re: ntdll: Remove more path trailing chars.

2011-04-05 Thread Juan Lang
Hi Vincent, > Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any > sense. > I saw that it is discouraged (forbidden ?) to depend on OS version in tests, > so I will avoid that path unless asked to follow it. > I've been advised on IRC to use "broken()", but I don't see h

Re: ntdll: Remove more path trailing chars.

2011-04-05 Thread Vincent Pelletier
Hi. Le samedi 02 avril 2011 09:16:53, Nikolay Sivov a écrit : > Please use table for test data and put your macro body in a loop. Done locally (indeed nicer). I have one more thing to figure out before posting again: how to deal with the NT4 failures testbot detected[1]. Those tests are boolean

Re: ntdll: Remove more path trailing chars.

2011-04-02 Thread Nikolay Sivov
On 4/2/2011 10:51, Vincent Pelletier wrote: Add tests via FindFirstFileA. Fixes bug 22635. --- dlls/kernel32/tests/file.c | 119 dlls/ntdll/path.c |8 +++- 2 files changed, 126 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32

Re: ntdll: Remove more path trailing chars.

2011-04-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10288 Your paranoid android