Andrew Cook writes:
> This will be my last submission for this piece of code, i want to work
> on other things and it's been almost 2 weeks with zero comments on my
> previous submission.
It's clearly not ready, and you already know that since you've added
TODOs all over the place.
--
Alexandr
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=26885
Your paranoid android
Andrew Cook wrote:
> On 27/08/13 22:02, Dmitry Timoshkov wrote:
> > Andrew Cook wrote:
> >> --- a/include/wine/server_protocol.h
> >> +++ b/include/wine/server_protocol.h
> >
> > And don't include autogenerated stuff in the patch.
> >
>
> Is there anything about this on the wiki? i wasn't sur
On 27/08/13 22:02, Dmitry Timoshkov wrote:
> Andrew Cook wrote:
>> --- a/include/wine/server_protocol.h
>> +++ b/include/wine/server_protocol.h
>
> And don't include autogenerated stuff in the patch.
>
Is there anything about this on the wiki? i wasn't sure how
autogenerated files are supposed
Andrew Cook wrote:
> +typedef struct _JOBOBJECT_ASSOCIATE_COMPLETION_PORT {
> + PVOID CompletionKey;
> + HANDLE CompletionPort;
> +} JOBOBJECT_ASSOCIATE_COMPLETION_PORT, *PJOBOBJECT_ASSOCIATE_COMPLETION_PORT;
This needs to go into its owm header.
> +static DWORD getProcess(PHANDLE handle) {
